Issue 1104463004: Fix closure compiling error of file manager.

Issue 1104463004: Fix closure compiling error of file manager. (Closed)

Created:
5 years, 8 months ago by fukino

Modified:
5 years, 8 months ago

Reviewers:
mtomasz, hirono

CC:
mtomasz, chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, dbeam+watch-closure_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix closure compiling error of file manager. BUG=none TEST=run closure compiler Committed: https://crrev.com/d32919d3f8274b051f6d506fe002c6c43f5185e4 Cr-Commit-Position: refs/heads/master@{#326737}

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
	M	third_party/closure_compiler/externs/file_manager_private.js	View		2 chunks	+34 lines, -0 lines	0 comments	Download
	M	ui/file_manager/file_manager/foreground/js/file_manager_commands.js	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104463004/1

5 years, 8 months ago (2015-04-24 03:41:30 UTC) #5

fukino

CCed mtomasz@, as the compile error in file_manager_commands.js looks a real bug.

5 years, 8 months ago (2015-04-24 03:43:22 UTC) #6

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/d32919d3f8274b051f6d506fe002c6c43f5185e4 Cr-Commit-Position: refs/heads/master@{#326737}

5 years, 8 months ago (2015-04-24 04:09:30 UTC) #8

Message was sent while issue was closed.

Sorry for breaking. Yes, it's a real bug. I'll fix it.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages