Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager_commands.js

Issue 1104463004: Fix closure compiling error of file manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/closure_compiler/externs/file_manager_private.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/js/file_manager_commands.js
diff --git a/ui/file_manager/file_manager/foreground/js/file_manager_commands.js b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
index 74c8dc45d4fcd3c3d1a0969fbbf2eaf954ff303c..743fb67c333805bd5a5a26ffe67c5aef3b6bca2f 100644
--- a/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
+++ b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
@@ -1251,6 +1251,7 @@ CommandHandler.COMMANDS_['add-new-services'] = /** @type {Command} */ ({
/**
* @param {!Event} event Command event.
* @param {!FileManager} fileManager FileManager to use.
+ * @suppress {checkTypes}
*/
execute: function(event, fileManager) {
fileManager.ui.suggestAppsDialog.showProviders(
@@ -1258,10 +1259,12 @@ CommandHandler.COMMANDS_['add-new-services'] = /** @type {Command} */ ({
// If a new provider is installed, then launch it so the configuration
// dialog is shown (if it's available).
if (result === SuggestAppsDialog.Result.SUCCESS) {
+ // TODO(mtomasz): Pass extension_id to addProvidedFileSystem.
chrome.fileManagerPrivate.addProvidedFileSystem(function() {
if (chrome.runtime.lastError) {
// TODO(mtomasz): Handle the error and let users uninstall the
// extension easily.
+ console.error(chrome.runtime.lastError.message);
}
});
}
« no previous file with comments | « third_party/closure_compiler/externs/file_manager_private.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698