Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Issue 1104453006: [turbofan] Introduce explicit JSCreateLiteral[Array|Object]. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce explicit JSCreateLiteral[Array|Object]. This uses explicit operators instead of intrinsic runtime calls to create literals froms boilerplates. It allows for easier access of static parameters and syncs it with other allocating operators. R=svenpanne@chromium.org Committed: https://crrev.com/d6e99a7f52cc8a9cdf0b956ce3836a9e1999bef1 Cr-Commit-Position: refs/heads/master@{#28062}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -126 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 3 chunks +0 lines, -64 lines 0 comments Download
M src/compiler/js-operator.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 2 chunks +62 lines, -0 lines 0 comments Download
M src/compiler/linkage.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 2 chunks +0 lines, -52 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 8 months ago (2015-04-23 11:05:09 UTC) #1
Sven Panne
LGTM. Bonus points for trimming the #includes back. :-)
5 years, 8 months ago (2015-04-23 12:13:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104453006/20001
5 years, 8 months ago (2015-04-27 09:33:49 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-27 09:57:52 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 09:58:02 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6e99a7f52cc8a9cdf0b956ce3836a9e1999bef1
Cr-Commit-Position: refs/heads/master@{#28062}

Powered by Google App Engine
This is Rietveld 408576698