Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1104453006: [turbofan] Introduce explicit JSCreateLiteral[Array|Object]. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebased. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index 03fee5847d11a9ba0326e74cc45abe865077803e..933f466f163368b3b03ca09ac31b513ba00fa8b8 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -1660,10 +1660,9 @@ void AstGraphBuilder::VisitObjectLiteral(ObjectLiteral* expr) {
BuildLoadObjectField(closure, JSFunction::kLiteralsOffset);
Node* literal_index = jsgraph()->Constant(expr->literal_index());
Node* constants = jsgraph()->Constant(expr->constant_properties());
- Node* flags = jsgraph()->Constant(expr->ComputeFlags(true));
const Operator* op =
- javascript()->CallRuntime(Runtime::kInlineCreateObjectLiteral, 4);
- Node* literal = NewNode(op, literals_array, literal_index, constants, flags);
+ javascript()->CreateLiteralObject(expr->ComputeFlags(true));
+ Node* literal = NewNode(op, literals_array, literal_index, constants);
PrepareFrameState(literal, expr->CreateLiteralId(),
OutputFrameStateCombine::Push());
@@ -1852,10 +1851,9 @@ void AstGraphBuilder::VisitArrayLiteral(ArrayLiteral* expr) {
BuildLoadObjectField(closure, JSFunction::kLiteralsOffset);
Node* literal_index = jsgraph()->Constant(expr->literal_index());
Node* constants = jsgraph()->Constant(expr->constant_elements());
- Node* flags = jsgraph()->Constant(expr->ComputeFlags(true));
const Operator* op =
- javascript()->CallRuntime(Runtime::kInlineCreateArrayLiteral, 4);
- Node* literal = NewNode(op, literals_array, literal_index, constants, flags);
+ javascript()->CreateLiteralArray(expr->ComputeFlags(true));
+ Node* literal = NewNode(op, literals_array, literal_index, constants);
PrepareFrameState(literal, expr->CreateLiteralId(),
OutputFrameStateCombine::Push());
« no previous file with comments | « no previous file | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698