Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1104303002: fix assertion in Logger::CurrentTimeEvent with --prof (Closed)

Created:
5 years, 7 months ago by ofrobots
Modified:
5 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

fix assertion in Logger::CurrentTimeEvent with --prof assertion did match the conditions under which this method gets called (Runtime_DateCurrentTime). The bug got introduced as part of this change: https://codereview.chromium.org/802333002 The assertion crash can be reproduced using: % out/Debug/d8 --prof -e 'new Date();' R=jkummerow@chromium.org BUG= Committed: https://crrev.com/1f03256de37aaa1b1cbe81d56122defa0ad9aa9a Cr-Commit-Position: refs/heads/master@{#28096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/log.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ofrobots
5 years, 7 months ago (2015-04-27 18:19:11 UTC) #1
Jakob Kummerow
LGTM, thanks for the patch. Note that using --prof in Debug mode can be very ...
5 years, 7 months ago (2015-04-28 08:30:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104303002/1
5 years, 7 months ago (2015-04-28 08:31:12 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 08:54:21 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 08:54:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f03256de37aaa1b1cbe81d56122defa0ad9aa9a
Cr-Commit-Position: refs/heads/master@{#28096}

Powered by Google App Engine
This is Rietveld 408576698