Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 802333002: Profiler improvements (Closed)

Created:
6 years ago by Jakob Kummerow
Modified:
5 years, 11 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Profiler improvements (1) --prof-cpp: Collects ticks like --prof, but ignores code creation events to reduce distortion (so all JS ticks will be "unaccounted"). Useful for profiling C++ code. (2) --timed-range flag for tick processor: Ignores ticks before the first and after the last call to Date.now(). Useful for focusing on the timed section of a test. Committed: https://crrev.com/feffccca22cb63f39f8170b392e0ca05145e6403 Cr-Commit-Position: refs/heads/master@{#26168}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebased #

Patch Set 3 : updated test expectations; improved tickprocessor tests failure output #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -60 lines) Patch
M src/flag-definitions.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 1 chunk +0 lines, -13 lines 0 comments Download
M src/log.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/log-utils.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/runtime/runtime-date.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/tools/tickprocessor.js View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M test/mjsunit/tools/tickprocessor-test.default View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/tools/tickprocessor-test.ignore-unknown View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/tools/tickprocessor-test.separate-ic View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M tools/logreader.js View 3 chunks +37 lines, -2 lines 0 comments Download
M tools/profile.js View 1 chunk +15 lines, -13 lines 0 comments Download
M tools/tickprocessor.js View 5 chunks +11 lines, -5 lines 0 comments Download
M tools/tickprocessor-driver.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Jakob Kummerow
PTAL whenever you have time (next year is fine).
6 years ago (2014-12-15 12:06:58 UTC) #2
Jakob Kummerow
https://codereview.chromium.org/802333002/diff/1/src/isolate.cc File src/isolate.cc (left): https://codereview.chromium.org/802333002/diff/1/src/isolate.cc#oldcode2100 src/isolate.cc:2100: // If we are deserializing, log non-function code objects ...
6 years ago (2014-12-15 12:09:15 UTC) #3
Yang
On 2014/12/15 12:09:15, Jakob wrote: > https://codereview.chromium.org/802333002/diff/1/src/isolate.cc > File src/isolate.cc (left): > > https://codereview.chromium.org/802333002/diff/1/src/isolate.cc#oldcode2100 > ...
5 years, 11 months ago (2015-01-08 13:32:36 UTC) #4
Yang
https://codereview.chromium.org/802333002/diff/1/src/isolate.cc File src/isolate.cc (left): https://codereview.chromium.org/802333002/diff/1/src/isolate.cc#oldcode2100 src/isolate.cc:2100: // If we are deserializing, log non-function code objects ...
5 years, 11 months ago (2015-01-08 13:32:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802333002/20001
5 years, 11 months ago (2015-01-19 15:06:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/742) v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2173)
5 years, 11 months ago (2015-01-19 15:28:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/802333002/40001
5 years, 11 months ago (2015-01-20 14:22:01 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-20 16:06:09 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-20 16:06:15 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/feffccca22cb63f39f8170b392e0ca05145e6403
Cr-Commit-Position: refs/heads/master@{#26168}

Powered by Google App Engine
This is Rietveld 408576698