Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1104293002: Oilpan: put MessageChannel on the heap. (Closed)

Created:
5 years, 8 months ago by sof
Modified:
5 years, 7 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, falken, vivekg, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, kinuko+worker_chromium.org, horo+watch_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: put MessageChannel on the heap. R=kouhei BUG=479467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194572

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/MessageChannel.h View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/dom/MessageChannel.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorker.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
sof
please take a look.
5 years, 8 months ago (2015-04-27 20:17:14 UTC) #2
kouhei (in TOK)
lgtm
5 years, 8 months ago (2015-04-27 21:34:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104293002/1
5 years, 8 months ago (2015-04-27 21:36:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/32209)
5 years, 8 months ago (2015-04-27 21:43:13 UTC) #8
haraken
LGTM
5 years, 8 months ago (2015-04-28 00:49:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104293002/1
5 years, 7 months ago (2015-04-28 05:04:00 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 05:07:35 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194572

Powered by Google App Engine
This is Rietveld 408576698