Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp

Issue 1104293002: Oilpan: put MessageChannel on the heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/MessageChannel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp b/Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp
index cac66e600ec3af618c93124fbbfd2a6ed1195edc..96c7ecf25d136f449934981f6dc6b4035fdca12c 100644
--- a/Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8MessageChannelCustom.cpp
@@ -44,17 +44,17 @@ void V8MessageChannel::constructorCustom(const v8::FunctionCallbackInfo<v8::Valu
{
ExecutionContext* context = currentExecutionContext(info.GetIsolate());
- RefPtrWillBeRawPtr<MessageChannel> obj = MessageChannel::create(context);
+ MessageChannel* channel = MessageChannel::create(context);
v8::Local<v8::Object> wrapper = info.Holder();
// Create references from the MessageChannel wrapper to the two
// MessagePort wrappers to make sure that the MessagePort wrappers
// stay alive as long as the MessageChannel wrapper is around.
- V8HiddenValue::setHiddenValue(info.GetIsolate(), wrapper, V8HiddenValue::port1(info.GetIsolate()), toV8(obj->port1(), info.Holder(), info.GetIsolate()));
- V8HiddenValue::setHiddenValue(info.GetIsolate(), wrapper, V8HiddenValue::port2(info.GetIsolate()), toV8(obj->port2(), info.Holder(), info.GetIsolate()));
+ V8HiddenValue::setHiddenValue(info.GetIsolate(), wrapper, V8HiddenValue::port1(info.GetIsolate()), toV8(channel->port1(), info.Holder(), info.GetIsolate()));
+ V8HiddenValue::setHiddenValue(info.GetIsolate(), wrapper, V8HiddenValue::port2(info.GetIsolate()), toV8(channel->port2(), info.Holder(), info.GetIsolate()));
- V8DOMWrapper::associateObjectWithWrapper(info.GetIsolate(), obj.get(), &wrapperTypeInfo, wrapper);
+ V8DOMWrapper::associateObjectWithWrapper(info.GetIsolate(), channel, &wrapperTypeInfo, wrapper);
info.GetReturnValue().Set(wrapper);
}
« no previous file with comments | « no previous file | Source/core/dom/MessageChannel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698