cr: Fix gn argument generation in a release build

cr: Fix gn argument generation in a release build

The condition was being misinterpreted because of missing braces.

Committed: https://crrev.com/8365bb185bf7af6ad151b9d5e5931289d9e22b33
Cr-Commit-Position: refs/heads/master@{#327071}

[Sami, 2015-04-27 17:42:26]

skyostil@chromium.org changed reviewers:
+ petrcermak@chromium.org

[petrcermak, 2015-04-27 17:57:23]

LGTM + 1 observation.

Thanks,
Petr

https://codereview.chromium.org/1104263002/diff/1/tools/cr/cr/actions/gn.py
File tools/cr/cr/actions/gn.py (right):

https://codereview.chromium.org/1104263002/diff/1/tools/cr/cr/actions/gn.py#n...
tools/cr/cr/actions/gn.py:38: ('true' if cr.context['CR_BUILDTYPE'] == 'Debug'
else 'false'))
Another option would be to do:

str(cr.context['CR_BUILDTYPE'] == 'Debug').lower()

but that might be less readable.

[Sami, 2015-04-27 17:58:57]

https://codereview.chromium.org/1104263002/diff/1/tools/cr/cr/actions/gn.py
File tools/cr/cr/actions/gn.py (right):

https://codereview.chromium.org/1104263002/diff/1/tools/cr/cr/actions/gn.py#n...
tools/cr/cr/actions/gn.py:38: ('true' if cr.context['CR_BUILDTYPE'] == 'Debug'
else 'false'))
On 2015/04/27 17:57:23, petrcermak wrote:
> Another option would be to do:
> 
> str(cr.context['CR_BUILDTYPE'] == 'Debug').lower()
> 
> but that might be less readable.

Heh, neat idea. I think there's too much magic going on here already though :)

[Sami, 2015-04-27 17:59:01]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2015-04-27 18:00:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1104263002/1

[commit-bot: I haz the power, 2015-04-27 18:10:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-04-27 18:11:20]

Patchset 1 (id:??) landed as
https://crrev.com/8365bb185bf7af6ad151b9d5e5931289d9e22b33
Cr-Commit-Position: refs/heads/master@{#327071}