tools/cr/cr/actions/gn.py - Issue 1104263002: cr: Fix gn argument generation in a release build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/cr/cr/actions/gn.py

Issue 1104263002: cr: Fix gn argument generation in a release build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/cr/cr/actions/gn.py

diff --git a/tools/cr/cr/actions/gn.py b/tools/cr/cr/actions/gn.py

index 7c3ca3a269bdabfb486032f648fdd34020f8e0cc..e532d1d77c18e77a3ddd61313440ac6bcdfe8b3f 100644

--- a/tools/cr/cr/actions/gn.py

+++ b/tools/cr/cr/actions/gn.py

@@ -35,7 +35,7 @@ class GnPrepareOut(cr.PrepareOut):

gn_args += ' %s=%s' % (key[len(GN_ARG_PREFIX):], value)

gn_args += (' is_debug=%s' %

- 'true' if cr.context['CR_BUILDTYPE'] == 'Debug' else 'false')

+ ('true' if cr.context['CR_BUILDTYPE'] == 'Debug' else 'false'))

petrcermak 2015/04/27 17:57:23 Another option would be to do: str(cr.context['CR

Sami 2015/04/27 17:58:57 Heh, neat idea. I think there's too much magic goi

# Detect goma.

goma_binaries = cr.Host.SearchPath('gomacc', [

« no previous file with comments | « no previous file | no next file » | no next file with comments »