Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1934)

Issue 110413007: Fix truncated location bar on maximized streamlined hosted apps. (Closed)

Created:
6 years, 11 months ago by calamity
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix truncated location bar on maximized streamlined hosted apps. Streamlined Hosted App windows were having their location bar truncated when maximized. This was due to using the popup-style location bar to get the omnibox to be read-only. This CL changes streamlined hosted apps to use the normal location bar and sets the omnibox to be read only at a deeper level. BUG=318607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243705

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 3 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
calamity
6 years, 11 months ago (2013-12-31 05:26:48 UTC) #1
sky
LGTM
6 years, 11 months ago (2014-01-06 18:51:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/110413007/1
6 years, 11 months ago (2014-01-07 00:05:41 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/views/location_bar/location_bar_view.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-07 00:05:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/110413007/120001
6 years, 11 months ago (2014-01-08 02:53:55 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=243009
6 years, 11 months ago (2014-01-08 04:54:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/110413007/120001
6 years, 11 months ago (2014-01-08 22:37:37 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 00:12:42 UTC) #8
Message was sent while issue was closed.
Change committed as 243705

Powered by Google App Engine
This is Rietveld 408576698