Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: chrome/browser/ui/views/toolbar/toolbar_view.cc

Issue 110413007: Fix truncated location bar on maximized streamlined hosted apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/toolbar/toolbar_view.h" 5 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/debug/trace_event.h" 8 #include "base/debug/trace_event.h"
9 #include "base/i18n/number_formatting.h" 9 #include "base/i18n/number_formatting.h"
10 #include "base/prefs/pref_service.h" 10 #include "base/prefs/pref_service.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 const int kContentShadowHeightAsh = 2; 96 const int kContentShadowHeightAsh = 2;
97 97
98 // Non-ash uses a rounded content area with no shadow in the assets. 98 // Non-ash uses a rounded content area with no shadow in the assets.
99 const int kContentShadowHeight = 0; 99 const int kContentShadowHeight = 0;
100 100
101 int GetButtonSpacing() { 101 int GetButtonSpacing() {
102 return (ui::GetDisplayLayout() == ui::LAYOUT_TOUCH) ? 102 return (ui::GetDisplayLayout() == ui::LAYOUT_TOUCH) ?
103 ToolbarView::kStandardSpacing : 0; 103 ToolbarView::kStandardSpacing : 0;
104 } 104 }
105 105
106 bool IsStreamlinedHostedAppsEnabled() {
107 return CommandLine::ForCurrentProcess()->HasSwitch(
108 switches::kEnableStreamlinedHostedApps);
109 }
110
111 } // namespace 106 } // namespace
112 107
113 // static 108 // static
114 const char ToolbarView::kViewClassName[] = "ToolbarView"; 109 const char ToolbarView::kViewClassName[] = "ToolbarView";
115 110
116 //////////////////////////////////////////////////////////////////////////////// 111 ////////////////////////////////////////////////////////////////////////////////
117 // ToolbarView, public: 112 // ToolbarView, public:
118 113
119 ToolbarView::ToolbarView(Browser* browser) 114 ToolbarView::ToolbarView(Browser* browser)
120 : back_(NULL), 115 : back_(NULL),
121 forward_(NULL), 116 forward_(NULL),
122 reload_(NULL), 117 reload_(NULL),
123 home_(NULL), 118 home_(NULL),
124 location_bar_(NULL), 119 location_bar_(NULL),
125 site_chip_view_(NULL), 120 site_chip_view_(NULL),
126 browser_actions_(NULL), 121 browser_actions_(NULL),
127 app_menu_(NULL), 122 app_menu_(NULL),
128 browser_(browser) { 123 browser_(browser) {
129 set_id(VIEW_ID_TOOLBAR); 124 set_id(VIEW_ID_TOOLBAR);
130 125
131 chrome::AddCommandObserver(browser_, IDC_BACK, this); 126 chrome::AddCommandObserver(browser_, IDC_BACK, this);
132 chrome::AddCommandObserver(browser_, IDC_FORWARD, this); 127 chrome::AddCommandObserver(browser_, IDC_FORWARD, this);
133 chrome::AddCommandObserver(browser_, IDC_RELOAD, this); 128 chrome::AddCommandObserver(browser_, IDC_RELOAD, this);
134 chrome::AddCommandObserver(browser_, IDC_HOME, this); 129 chrome::AddCommandObserver(browser_, IDC_HOME, this);
135 chrome::AddCommandObserver(browser_, IDC_LOAD_NEW_TAB_PAGE, this); 130 chrome::AddCommandObserver(browser_, IDC_LOAD_NEW_TAB_PAGE, this);
136 131
137 display_mode_ = DISPLAYMODE_LOCATION; 132 display_mode_ = DISPLAYMODE_LOCATION;
138 if (browser->SupportsWindowFeature(Browser::FEATURE_TABSTRIP) || 133 if (browser->SupportsWindowFeature(Browser::FEATURE_TABSTRIP) ||
139 (browser->is_app() && IsStreamlinedHostedAppsEnabled())) 134 (browser->is_app() && CommandLine::ForCurrentProcess()->HasSwitch(
135 switches::kEnableStreamlinedHostedApps)))
140 display_mode_ = DISPLAYMODE_NORMAL; 136 display_mode_ = DISPLAYMODE_NORMAL;
141 137
142 registrar_.Add(this, chrome::NOTIFICATION_UPGRADE_RECOMMENDED, 138 registrar_.Add(this, chrome::NOTIFICATION_UPGRADE_RECOMMENDED,
143 content::NotificationService::AllSources()); 139 content::NotificationService::AllSources());
144 if (OutdatedUpgradeBubbleView::IsAvailable()) { 140 if (OutdatedUpgradeBubbleView::IsAvailable()) {
145 registrar_.Add(this, chrome::NOTIFICATION_OUTDATED_INSTALL, 141 registrar_.Add(this, chrome::NOTIFICATION_OUTDATED_INSTALL,
146 content::NotificationService::AllSources()); 142 content::NotificationService::AllSources());
147 } 143 }
148 #if defined(OS_WIN) 144 #if defined(OS_WIN)
149 registrar_.Add(this, chrome::NOTIFICATION_CRITICAL_UPGRADE_INSTALLED, 145 registrar_.Add(this, chrome::NOTIFICATION_CRITICAL_UPGRADE_INSTALLED,
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 forward_->set_tag(IDC_FORWARD); 182 forward_->set_tag(IDC_FORWARD);
187 forward_->SetTooltipText(l10n_util::GetStringUTF16(IDS_TOOLTIP_FORWARD)); 183 forward_->SetTooltipText(l10n_util::GetStringUTF16(IDS_TOOLTIP_FORWARD));
188 forward_->SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_FORWARD)); 184 forward_->SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_FORWARD));
189 forward_->set_id(VIEW_ID_FORWARD_BUTTON); 185 forward_->set_id(VIEW_ID_FORWARD_BUTTON);
190 forward_->Init(); 186 forward_->Init();
191 187
192 // Have to create this before |reload_| as |reload_|'s constructor needs it. 188 // Have to create this before |reload_| as |reload_|'s constructor needs it.
193 location_bar_ = new LocationBarView( 189 location_bar_ = new LocationBarView(
194 browser_, browser_->profile(), 190 browser_, browser_->profile(),
195 browser_->command_controller()->command_updater(), this, 191 browser_->command_controller()->command_updater(), this,
196 display_mode_ == DISPLAYMODE_LOCATION || 192 display_mode_ == DISPLAYMODE_LOCATION);
197 (browser_->is_app() && IsStreamlinedHostedAppsEnabled()));
198 193
199 reload_ = new ReloadButton(location_bar_, 194 reload_ = new ReloadButton(location_bar_,
200 browser_->command_controller()->command_updater()); 195 browser_->command_controller()->command_updater());
201 reload_->set_triggerable_event_flags( 196 reload_->set_triggerable_event_flags(
202 ui::EF_LEFT_MOUSE_BUTTON | ui::EF_MIDDLE_MOUSE_BUTTON); 197 ui::EF_LEFT_MOUSE_BUTTON | ui::EF_MIDDLE_MOUSE_BUTTON);
203 reload_->set_tag(IDC_RELOAD); 198 reload_->set_tag(IDC_RELOAD);
204 reload_->SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_RELOAD)); 199 reload_->SetAccessibleName(l10n_util::GetStringUTF16(IDS_ACCNAME_RELOAD));
205 reload_->set_id(VIEW_ID_RELOAD_BUTTON); 200 reload_->set_id(VIEW_ID_RELOAD_BUTTON);
206 reload_->Init(); 201 reload_->Init();
207 202
(...skipping 607 matching lines...) Expand 10 before | Expand all | Expand 10 after
815 810
816 void ToolbarView::OnShowHomeButtonChanged() { 811 void ToolbarView::OnShowHomeButtonChanged() {
817 Layout(); 812 Layout();
818 SchedulePaint(); 813 SchedulePaint();
819 } 814 }
820 815
821 int ToolbarView::content_shadow_height() const { 816 int ToolbarView::content_shadow_height() const {
822 return browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH ? 817 return browser_->host_desktop_type() == chrome::HOST_DESKTOP_TYPE_ASH ?
823 kContentShadowHeightAsh : kContentShadowHeight; 818 kContentShadowHeightAsh : kContentShadowHeight;
824 } 819 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/location_bar/location_bar_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698