Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1104113002: Do more to avoid last-resort stop-the-world GC (Closed)

Created:
5 years, 8 months ago by Erik Corry Chromium.org
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do more to avoid last-resort stop-the-world GC BUG=chromium:481433 R=hpayer@chromium.org LOG=y Committed: https://crrev.com/da66e720a32baa0686bab3eb6c44e5d4a1b9ebcc Cr-Commit-Position: refs/heads/master@{#28082}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Always retry allocation 2x before panic #

Patch Set 3 : Spolling fiksed #

Patch Set 4 : Fix test-alloc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M src/heap/heap-inl.h View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 2 3 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Hannes Payer (out of office)
https://codereview.chromium.org/1104113002/diff/1/src/heap/heap-inl.h File src/heap/heap-inl.h (right): https://codereview.chromium.org/1104113002/diff/1/src/heap/heap-inl.h#newcode548 src/heap/heap-inl.h:548: "insufficient newspace freed"); \ Let's do unconditionally a retry ...
5 years, 8 months ago (2015-04-27 12:33:22 UTC) #1
Erik Corry Chromium.org
PTAL
5 years, 8 months ago (2015-04-27 12:39:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104113002/20001
5 years, 8 months ago (2015-04-27 12:40:28 UTC) #4
Hannes Payer (out of office)
lgtm
5 years, 8 months ago (2015-04-27 12:47:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104113002/60001
5 years, 8 months ago (2015-04-27 13:45:38 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-27 14:10:33 UTC) #9
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/da66e720a32baa0686bab3eb6c44e5d4a1b9ebcc Cr-Commit-Position: refs/heads/master@{#28082}
5 years, 8 months ago (2015-04-27 14:10:45 UTC) #10
Jakob Kummerow
5 years, 7 months ago (2015-04-28 10:56:47 UTC) #11
Message was sent while issue was closed.
I guess this also fixes https://code.google.com/p/v8/issues/detail?id=4005 ?

Powered by Google App Engine
This is Rietveld 408576698