Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1104093002: Eliminate an unnecessary AsMutable() call in BookmarkModel::RemoveNodeAndGetRemovedUrls() (Closed)

Created:
5 years, 8 months ago by Deepak
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate an unnecessary AsMutable() call in BookmarkModel::RemoveNodeAndGetRemovedUrls() BookmarkModel::RemoveNodeAndGetRemovedUrls() does not require AsMutable as sunction itself suggest RemoveNode and get its url, and parent() can return non const pointer. So AsMutable() is not required in this case. BUG=481500 Committed: https://crrev.com/66c3f8f0c969fc279ba5e37408ef0feef6851904 Cr-Commit-Position: refs/heads/master@{#327220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/bookmarks/browser/bookmark_model.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Deepak
PTAL at this small change. Thanks
5 years, 8 months ago (2015-04-27 11:28:18 UTC) #2
brettw
lgtm
5 years, 8 months ago (2015-04-27 17:23:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104093002/1
5 years, 8 months ago (2015-04-28 02:13:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-28 02:16:54 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 02:18:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66c3f8f0c969fc279ba5e37408ef0feef6851904
Cr-Commit-Position: refs/heads/master@{#327220}

Powered by Google App Engine
This is Rietveld 408576698