components/bookmarks/browser/bookmark_model.cc - Issue 1104093002: Eliminate an unnecessary AsMutable() call in BookmarkModel::RemoveNodeAndGetRemovedUrls()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/browser/bookmark_model.cc

Issue 1104093002: Eliminate an unnecessary AsMutable() call in BookmarkModel::RemoveNodeAndGetRemovedUrls() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/bookmarks/browser/bookmark_model.cc

diff --git a/components/bookmarks/browser/bookmark_model.cc b/components/bookmarks/browser/bookmark_model.cc

index 80808ca6b1b24706a318c418a6ad5207599ce166..10d5b2f24ea2dbd107fa88b87dd84bfa34cc30ed 100644

--- a/components/bookmarks/browser/bookmark_model.cc

+++ b/components/bookmarks/browser/bookmark_model.cc

@@ -886,7 +886,7 @@ void BookmarkModel::RemoveNodeAndGetRemovedUrls(BookmarkNode* node,

// This method does not explicitly acquires a lock.

url_lock_.AssertAcquired();

DCHECK(removed_urls);

- BookmarkNode* parent = AsMutable(node->parent());

+ BookmarkNode* parent = node->parent();

DCHECK(parent);

parent->Remove(node);

RemoveNode(node, removed_urls);

« no previous file with comments | « no previous file | no next file » | no next file with comments »