Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1104063002: Make EfficientLength public, as EfficientLengthIterable. (Closed)

Created:
5 years, 8 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Make EfficientLength public, as EfficientLengthIterable. R=iposva@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=45556

Patch Set 1 #

Patch Set 2 : Don't make EfficientLengthIterable expose implementation. #

Patch Set 3 : Tweak documentation. #

Total comments: 2

Patch Set 4 : Address comment. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -64 lines) Patch
M runtime/lib/array_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/collection_patch.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/immutable_map.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/lib/string_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 2 chunks +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/collection_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/constant_map.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_array.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/js_lib/linked_hash_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/iterable.dart View 1 2 3 2 chunks +32 lines, -1 line 0 comments Download
M sdk/lib/collection/list.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/collection/maps.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/collection/queue.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/collection/splay_tree.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/core/iterable.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/core/list.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/core/set.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/internal/iterable.dart View 9 chunks +10 lines, -24 lines 1 comment Download
M tests/corelib/growable_list_test.dart View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lasse Reichstein Nielsen
5 years, 8 months ago (2015-04-27 11:14:44 UTC) #2
kevmoo
DBC https://codereview.chromium.org/1104063002/diff/40001/sdk/lib/collection/iterable.dart File sdk/lib/collection/iterable.dart (right): https://codereview.chromium.org/1104063002/diff/40001/sdk/lib/collection/iterable.dart#newcode429 sdk/lib/collection/iterable.dart:429: int get length { throw new UnimplementedError("efficient length"); ...
5 years, 8 months ago (2015-04-27 13:24:21 UTC) #4
Ivan Posva
VM changes LGTM... -Ivan
5 years, 8 months ago (2015-04-27 16:02:34 UTC) #6
Lasse Reichstein Nielsen
https://codereview.chromium.org/1104063002/diff/40001/sdk/lib/collection/iterable.dart File sdk/lib/collection/iterable.dart (right): https://codereview.chromium.org/1104063002/diff/40001/sdk/lib/collection/iterable.dart#newcode429 sdk/lib/collection/iterable.dart:429: int get length { throw new UnimplementedError("efficient length"); } ...
5 years, 7 months ago (2015-05-05 08:10:45 UTC) #7
Søren Gjesse
lgtm https://codereview.chromium.org/1104063002/diff/60001/sdk/lib/internal/iterable.dart File sdk/lib/internal/iterable.dart (right): https://codereview.chromium.org/1104063002/diff/60001/sdk/lib/internal/iterable.dart#newcode661 sdk/lib/internal/iterable.dart:661: implements EfficientLengthIterable<E> { Indentation :-)
5 years, 7 months ago (2015-05-05 16:33:30 UTC) #8
Lasse Reichstein Nielsen
5 years, 7 months ago (2015-05-06 09:01:13 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 45556 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698