sdk/lib/_internal/compiler/js_lib/js_array.dart - Issue 1104063002: Make EfficientLength public, as EfficientLengthIterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_array.dart

Issue 1104063002: Make EfficientLength public, as EfficientLengthIterable. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/js_lib/constant_map.dart ('k') | sdk/lib/_internal/compiler/js_lib/js_helper.dart » ('j') | sdk/lib/internal/iterable.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/js_lib/js_array.dart

diff --git a/sdk/lib/_internal/compiler/js_lib/js_array.dart b/sdk/lib/_internal/compiler/js_lib/js_array.dart

index 2afabdd98e9694296f1f83ac3e377ba50042a0c7..4078d66731dc962f10382279817002805f73a7c5 100644

--- a/sdk/lib/_internal/compiler/js_lib/js_array.dart

+++ b/sdk/lib/_internal/compiler/js_lib/js_array.dart

@@ -125,7 +125,7 @@ class JSArray<E> extends Interceptor implements List<E>, JSIndexable {

void insertAll(int index, Iterable<E> iterable) {

checkGrowable('insertAll');

RangeError.checkValueInInterval(index, 0, this.length, "index");

- if (iterable is! EfficientLength) {

+ if (iterable is! EfficientLengthIterable) {

iterable = iterable.toList();

}

int insertionLength = iterable.length;

@@ -440,7 +440,7 @@ class JSArray<E> extends Interceptor implements List<E>, JSIndexable {

void replaceRange(int start, int end, Iterable<E> replacement) {

checkGrowable('replace range');

RangeError.checkValidRange(start, end, this.length);

- if (replacement is! EfficientLength) {

+ if (replacement is! EfficientLengthIterable) {

replacement = replacement.toList();

}

int removeLength = end - start;

« no previous file with comments | « sdk/lib/_internal/compiler/js_lib/constant_map.dart ('k') | sdk/lib/_internal/compiler/js_lib/js_helper.dart » ('j') | sdk/lib/internal/iterable.dart » ('J')