Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1104053004: Cleanup: removing unused descendants information from tracked objects (Closed)

Created:
5 years, 7 months ago by vadimt
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: removing unused descendants information from tracked objects. BUG=456354 Committed: https://crrev.com/cf8983ef6ccb5101181b2f854023b2124dd31882 Cr-Commit-Position: refs/heads/master@{#327956}

Patch Set 1 #

Total comments: 4

Patch Set 2 : isherman@ comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -271 lines) Patch
M base/debug/task_annotator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/profiler/scoped_profile.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/profiler/tracked_time_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/threading/worker_pool_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/threading/worker_pool_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M base/tracked_objects.h View 1 11 chunks +10 lines, -72 lines 0 comments Download
M base/tracked_objects.cc View 10 chunks +5 lines, -70 lines 0 comments Download
M base/tracked_objects_unittest.cc View 28 chunks +26 lines, -79 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/task_profiler/task_profiler_data_serializer.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M content/common/child_process_messages.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
vadimt
5 years, 7 months ago (2015-04-29 20:39:32 UTC) #2
Ilya Sherman
LGTM. Thanks, Vadim. https://codereview.chromium.org/1104053004/diff/1/base/tracked_objects.h File base/tracked_objects.h (right): https://codereview.chromium.org/1104053004/diff/1/base/tracked_objects.h#newcode425 base/tracked_objects.h:425: UNINITIALIZED, // PRistine, link-time state before ...
5 years, 7 months ago (2015-04-30 05:30:28 UTC) #3
Alexei Svitkine (slow)
lgtm
5 years, 7 months ago (2015-04-30 14:31:03 UTC) #4
vadimt
https://codereview.chromium.org/1104053004/diff/1/base/tracked_objects.h File base/tracked_objects.h (right): https://codereview.chromium.org/1104053004/diff/1/base/tracked_objects.h#newcode425 base/tracked_objects.h:425: UNINITIALIZED, // PRistine, link-time state before running. On 2015/04/30 ...
5 years, 7 months ago (2015-04-30 20:37:43 UTC) #5
vadimt
cpu@, please provide OWNERs approval. Note that we change the IPC protocol, but only by ...
5 years, 7 months ago (2015-04-30 20:39:15 UTC) #7
vadimt
Ah, you aren't an owner of child_process_messages.h (per the cr tool)... I'll add a reviewer.
5 years, 7 months ago (2015-04-30 20:40:36 UTC) #8
vadimt
dcheng@chromium.org: Please review changes in child_process_messages.h
5 years, 7 months ago (2015-04-30 20:42:07 UTC) #10
dcheng
rs lgtm for removal-only IPC changes
5 years, 7 months ago (2015-04-30 20:43:04 UTC) #11
cpu_(ooo_6.6-7.5)
lgtm
5 years, 7 months ago (2015-05-01 02:13:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104053004/20001
5 years, 7 months ago (2015-05-01 14:10:56 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/54408)
5 years, 7 months ago (2015-05-01 16:47:07 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104053004/20001
5 years, 7 months ago (2015-05-01 17:58:12 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-01 19:13:14 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 19:15:10 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf8983ef6ccb5101181b2f854023b2124dd31882
Cr-Commit-Position: refs/heads/master@{#327956}

Powered by Google App Engine
This is Rietveld 408576698