Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc

Issue 1104053004: Cleanup: removing unused descendants information from tracked objects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: isherman@ comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc
diff --git a/chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc b/chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc
index c9a72e6cae41d0eb05149f7b7bf75864b40ed12a..da040b78bab0302146de9edecabeee271ab167fb 100644
--- a/chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc
+++ b/chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc
@@ -41,8 +41,6 @@ TEST(TaskProfilerDataSerializerTest, SerializeProcessDataToJson) {
int process_type = content::PROCESS_TYPE_BROWSER;
ExpectSerialization(process_data_phase, 239, process_type,
"{"
- "\"descendants\":["
- "],"
"\"list\":["
"],"
"\"process_id\":239,"
@@ -92,31 +90,9 @@ TEST(TaskProfilerDataSerializerTest, SerializeProcessDataToJson) {
process_data_phase.tasks.back().death_data.queue_duration_sum = 2079;
process_data_phase.tasks.back().death_thread_name = "PAC thread #3";
- // Add a parent-child pair.
- process_data_phase.descendants.push_back(
- tracked_objects::ParentChildPairSnapshot());
- process_data_phase.descendants.back().parent = parent;
- process_data_phase.descendants.back().child = child;
-
int process_type = content::PROCESS_TYPE_RENDERER;
ExpectSerialization(process_data_phase, 239, process_type,
"{"
- "\"descendants\":["
- "{"
- "\"child_location\":{"
- "\"file_name\":\"path/to/bar.cc\","
- "\"function_name\":\"FizzBoom\","
- "\"line_number\":433"
- "},"
- "\"child_thread\":\"Chrome_IOThread\","
- "\"parent_location\":{"
- "\"file_name\":\"path/to/foo.cc\","
- "\"function_name\":\"WhizBang\","
- "\"line_number\":101"
- "},"
- "\"parent_thread\":\"CrBrowserMain\""
- "}"
- "],"
"\"list\":[{"
"\"birth_location\":{"
"\"file_name\":\"path/to/foo.cc\","
« no previous file with comments | « chrome/browser/task_profiler/task_profiler_data_serializer.cc ('k') | content/common/child_process_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698