Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1104043002: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/prerender/, prefetch and printing (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, davidben+watch_chromium.org, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/prerender/, prefetch and printing module BUG=466848 TBR=gavinp@chromium.org Committed: https://crrev.com/bcce43beb91324aebed2f5bc5ccad231406a1ca9 Cr-Commit-Position: refs/heads/master@{#327657}

Patch Set 1 #

Patch Set 2 : Adding files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M chrome/browser/prefetch/prefetch.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_message_filter.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/printing/print_job_manager.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
anujsharma
vitalybuka@chromium.org: Please review changes in chrome/browser/printing gavinp@chromium.org: Please review changes in chrome/browser/prerender/ and prefetch
5 years, 7 months ago (2015-04-27 10:47:03 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 7 months ago (2015-04-27 18:07:02 UTC) #3
anujsharma
@Gavnip Could you please give a thumbs up for this CL. Thanks!!
5 years, 7 months ago (2015-04-29 12:09:57 UTC) #4
davidben
prerender lgtm
5 years, 7 months ago (2015-04-29 15:38:35 UTC) #6
anujsharma
Since it is very trivial change, adding gavnip as TBR. Trying to land.
5 years, 7 months ago (2015-04-30 05:03:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104043002/20001
5 years, 7 months ago (2015-04-30 05:04:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-30 06:37:29 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 06:38:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bcce43beb91324aebed2f5bc5ccad231406a1ca9
Cr-Commit-Position: refs/heads/master@{#327657}

Powered by Google App Engine
This is Rietveld 408576698