Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: chrome/browser/prerender/prerender_message_filter.cc

Issue 1104043002: favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/prerender/, prefetch and printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding files Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/prerender/prerender_message_filter.h" 5 #include "chrome/browser/prerender/prerender_message_filter.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/memory/singleton.h" 8 #include "base/memory/singleton.h"
9 #include "chrome/browser/prerender/prerender_link_manager.h" 9 #include "chrome/browser/prerender/prerender_link_manager.h"
10 #include "chrome/browser/prerender/prerender_link_manager_factory.h" 10 #include "chrome/browser/prerender/prerender_link_manager_factory.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 BrowserThread::UI, FROM_HERE, 89 BrowserThread::UI, FROM_HERE,
90 base::Bind(&PrerenderMessageFilter::OnChannelClosingInUIThread, this)); 90 base::Bind(&PrerenderMessageFilter::OnChannelClosingInUIThread, this));
91 } 91 }
92 92
93 void PrerenderMessageFilter::OnAddPrerender( 93 void PrerenderMessageFilter::OnAddPrerender(
94 int prerender_id, 94 int prerender_id,
95 const PrerenderAttributes& attributes, 95 const PrerenderAttributes& attributes,
96 const content::Referrer& referrer, 96 const content::Referrer& referrer,
97 const gfx::Size& size, 97 const gfx::Size& size,
98 int render_view_route_id) { 98 int render_view_route_id) {
99 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 99 DCHECK_CURRENTLY_ON(BrowserThread::UI);
100 if (!prerender_link_manager_) 100 if (!prerender_link_manager_)
101 return; 101 return;
102 prerender_link_manager_->OnAddPrerender( 102 prerender_link_manager_->OnAddPrerender(
103 render_process_id_, prerender_id, 103 render_process_id_, prerender_id,
104 attributes.url, attributes.rel_types, referrer, 104 attributes.url, attributes.rel_types, referrer,
105 size, render_view_route_id); 105 size, render_view_route_id);
106 } 106 }
107 107
108 void PrerenderMessageFilter::OnCancelPrerender( 108 void PrerenderMessageFilter::OnCancelPrerender(
109 int prerender_id) { 109 int prerender_id) {
110 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 110 DCHECK_CURRENTLY_ON(BrowserThread::UI);
111 if (!prerender_link_manager_) 111 if (!prerender_link_manager_)
112 return; 112 return;
113 prerender_link_manager_->OnCancelPrerender(render_process_id_, prerender_id); 113 prerender_link_manager_->OnCancelPrerender(render_process_id_, prerender_id);
114 } 114 }
115 115
116 void PrerenderMessageFilter::OnAbandonPrerender( 116 void PrerenderMessageFilter::OnAbandonPrerender(
117 int prerender_id) { 117 int prerender_id) {
118 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 118 DCHECK_CURRENTLY_ON(BrowserThread::UI);
119 if (!prerender_link_manager_) 119 if (!prerender_link_manager_)
120 return; 120 return;
121 prerender_link_manager_->OnAbandonPrerender(render_process_id_, prerender_id); 121 prerender_link_manager_->OnAbandonPrerender(render_process_id_, prerender_id);
122 } 122 }
123 123
124 void PrerenderMessageFilter::ShutdownOnUIThread() { 124 void PrerenderMessageFilter::ShutdownOnUIThread() {
125 prerender_link_manager_ = nullptr; 125 prerender_link_manager_ = nullptr;
126 shutdown_notifier_.reset(); 126 shutdown_notifier_.reset();
127 } 127 }
128 128
129 void PrerenderMessageFilter::OnChannelClosingInUIThread() { 129 void PrerenderMessageFilter::OnChannelClosingInUIThread() {
130 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 130 DCHECK_CURRENTLY_ON(BrowserThread::UI);
131 if (!prerender_link_manager_) 131 if (!prerender_link_manager_)
132 return; 132 return;
133 prerender_link_manager_->OnChannelClosing(render_process_id_); 133 prerender_link_manager_->OnChannelClosing(render_process_id_);
134 } 134 }
135 135
136 } // namespace prerender 136 } // namespace prerender
137 137
OLDNEW
« no previous file with comments | « chrome/browser/prerender/prerender_manager.cc ('k') | chrome/browser/printing/print_job_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698