Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 1104023002: use 'branding_path_component' to simplify branding in chrome directory - part 1 (Closed)

Created:
5 years, 8 months ago by gburanov
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

use 'branding_path_component' to simplify branding in chrome directory - part 1 Please take look at https://codereview.chromium.org/1090213002/patch/40001/50001 for details BUG= Committed: https://crrev.com/f71ac8caefe44b71c75b0102e0d9edafabd6c8ee Cr-Commit-Position: refs/heads/master@{#327465}

Patch Set 1 #

Patch Set 2 : use branding_path_component for repack locales #

Patch Set 3 : try to fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -52 lines) Patch
M chrome/chrome_common.gypi View 1 2 1 chunk +1 line, -13 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 2 3 chunks +4 lines, -25 lines 0 comments Download
M chrome/chrome_repack_locales.gypi View 1 1 chunk +1 line, -5 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
gburanov
5 years, 8 months ago (2015-04-27 09:25:13 UTC) #2
sky
LGTM
5 years, 7 months ago (2015-04-28 23:30:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104023002/20001
5 years, 7 months ago (2015-04-29 05:34:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/47684) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-04-29 05:43:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1104023002/40001
5 years, 7 months ago (2015-04-29 09:15:36 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-04-29 10:08:16 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 10:10:01 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f71ac8caefe44b71c75b0102e0d9edafabd6c8ee
Cr-Commit-Position: refs/heads/master@{#327465}

Powered by Google App Engine
This is Rietveld 408576698