chrome/chrome_repack_locales.gypi - Issue 1104023002: use 'branding_path_component' to simplify branding in chrome directory - part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_repack_locales.gypi

Issue 1104023002: use 'branding_path_component' to simplify branding in chrome directory - part 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: try to fix build Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_repack_locales.gypi

diff --git a/chrome/chrome_repack_locales.gypi b/chrome/chrome_repack_locales.gypi

index b7096c2c48aeda7c001a360712a5448e0e0bae54..d76e1c7913bdedd44ffb719f2f00496331c74858 100644

--- a/chrome/chrome_repack_locales.gypi

+++ b/chrome/chrome_repack_locales.gypi

@@ -8,12 +8,8 @@

'variables': {

'repack_locales_path': 'tools/build/repack_locales.py',

'repack_options%': [],

+ 'branding_flag': ['-b', '<(branding_path_component)',],

'conditions': [

- ['branding=="Chrome"', {

- 'branding_flag': ['-b', 'google_chrome',],

- }, { # else: branding!="Chrome"

- 'branding_flag': ['-b', 'chromium',],

- }],

['chromeos==1', {

'chromeos_flag': ['--chromeos=1'],

}, {

« no previous file with comments | « chrome/chrome_exe.gypi ('k') | chrome/chrome_resources.gyp » ('j') | no next file with comments »