Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/ic-inl.h

Issue 11040021: Fix slot recording of code target patches. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Ulan Degenbaev. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/mark-compact.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 #ifdef DEBUG 84 #ifdef DEBUG
85 // STORE_IC and KEYED_STORE_IC use Code::extra_ic_state() to mark 85 // STORE_IC and KEYED_STORE_IC use Code::extra_ic_state() to mark
86 // ICs as strict mode. The strict-ness of the IC must be preserved. 86 // ICs as strict mode. The strict-ness of the IC must be preserved.
87 if (old_target->kind() == Code::STORE_IC || 87 if (old_target->kind() == Code::STORE_IC ||
88 old_target->kind() == Code::KEYED_STORE_IC) { 88 old_target->kind() == Code::KEYED_STORE_IC) {
89 ASSERT(Code::GetStrictMode(old_target->extra_ic_state()) == 89 ASSERT(Code::GetStrictMode(old_target->extra_ic_state()) ==
90 Code::GetStrictMode(target->extra_ic_state())); 90 Code::GetStrictMode(target->extra_ic_state()));
91 } 91 }
92 #endif 92 #endif
93 Assembler::set_target_address_at(address, target->instruction_start()); 93 Assembler::set_target_address_at(address, target->instruction_start());
94 if (heap->gc_state() == Heap::MARK_COMPACT && 94 if (heap->gc_state() == Heap::MARK_COMPACT) {
95 heap->mark_compact_collector()->is_compacting()) { 95 heap->mark_compact_collector()->RecordCodeTargetPatch(address, target);
96 Code* host = heap->isolate()->inner_pointer_to_code_cache()->
97 GcSafeFindCodeForInnerPointer(address);
98 RelocInfo rinfo(address, RelocInfo::CODE_TARGET, 0, host);
99 heap->mark_compact_collector()->RecordRelocSlot(&rinfo, target);
100 } else { 96 } else {
101 heap->incremental_marking()->RecordCodeTargetPatch(address, target); 97 heap->incremental_marking()->RecordCodeTargetPatch(address, target);
102 } 98 }
103 PostPatching(address, target, old_target); 99 PostPatching(address, target, old_target);
104 } 100 }
105 101
106 102
107 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object, 103 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object,
108 JSObject* holder) { 104 JSObject* holder) {
109 if (object->IsJSObject()) { 105 if (object->IsJSObject()) {
(...skipping 25 matching lines...) Expand all
135 JSObject* IC::GetCodeCacheHolder(Object* object, InlineCacheHolderFlag holder) { 131 JSObject* IC::GetCodeCacheHolder(Object* object, InlineCacheHolderFlag holder) {
136 Object* map_owner = (holder == OWN_MAP ? object : object->GetPrototype()); 132 Object* map_owner = (holder == OWN_MAP ? object : object->GetPrototype());
137 ASSERT(map_owner->IsJSObject()); 133 ASSERT(map_owner->IsJSObject());
138 return JSObject::cast(map_owner); 134 return JSObject::cast(map_owner);
139 } 135 }
140 136
141 137
142 } } // namespace v8::internal 138 } } // namespace v8::internal
143 139
144 #endif // V8_IC_INL_H_ 140 #endif // V8_IC_INL_H_
OLDNEW
« no previous file with comments | « no previous file | src/mark-compact.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698