Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 11040021: Fix slot recording of code target patches. (Closed)

Created:
8 years, 2 months ago by Michael Starzinger
Modified:
8 years, 2 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Fix slot recording of code target patches. This makes sure that we only record relocation slots for code target patches that happen in marked objects. Unmarked ones might be visited again, whereas marked ones are alive and will not be visited again. R=ulan@chromium.org BUG=chromium:152615, chromium:144230 Committed: https://code.google.com/p/v8/source/detail?r=12655

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Ulan Degenbaev. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M src/ic-inl.h View 1 chunk +2 lines, -6 lines 0 comments Download
M src/mark-compact.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mark-compact.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
8 years, 2 months ago (2012-10-02 08:59:19 UTC) #1
ulan
LGTM https://codereview.chromium.org/11040021/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/11040021/diff/1/src/mark-compact.cc#newcode4088 src/mark-compact.cc:4088: ASSERT(Marking::IsBlack(mark_bit)); Don't forget to remove this assert :)
8 years, 2 months ago (2012-10-02 11:39:06 UTC) #2
Michael Starzinger
8 years, 2 months ago (2012-10-02 15:44:33 UTC) #3
Addressed comments. Landing.

https://codereview.chromium.org/11040021/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/11040021/diff/1/src/mark-compact.cc#newcode4088
src/mark-compact.cc:4088: ASSERT(Marking::IsBlack(mark_bit));
On 2012/10/02 11:39:06, ulan wrote:
> Don't forget to remove this assert :)

Done. Oops, forgot that.

Powered by Google App Engine
This is Rietveld 408576698