Issue 11040021: Fix slot recording of code target patches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11040021: Fix slot recording of code target patches. (Closed)

Created:
8 years, 2 months ago by Michael Starzinger

Modified:
8 years, 2 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix slot recording of code target patches. This makes sure that we only record relocation slots for code target patches that happen in marked objects. Unmarked ones might be visited again, whereas marked ones are alive and will not be visited again. R=ulan@chromium.org BUG=chromium:152615, chromium:144230 Committed: https://code.google.com/p/v8/source/detail?r=12655

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Ulan Degenbaev. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -6 lines)			Patch
M	src/ic-inl.h	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/mark-compact.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM https://codereview.chromium.org/11040021/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/11040021/diff/1/src/mark-compact.cc#newcode4088 src/mark-compact.cc:4088: ASSERT(Marking::IsBlack(mark_bit)); Don't forget to remove this assert :)

8 years, 2 months ago (2012-10-02 11:39:06 UTC) #2

Michael Starzinger

8 years, 2 months ago (2012-10-02 15:44:33 UTC) #3

Addressed comments. Landing.

https://codereview.chromium.org/11040021/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/11040021/diff/1/src/mark-compact.cc#newcode4088
src/mark-compact.cc:4088: ASSERT(Marking::IsBlack(mark_bit));
On 2012/10/02 11:39:06, ulan wrote:
> Don't forget to remove this assert :)

Done. Oops, forgot that.

Expand Messages | Collapse Messages