Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 110373008: Remove Chrome Frame tests everywhere. (Closed)

Created:
7 years ago by grt (UTC plus 2)
Modified:
7 years ago
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org, xusydoc+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Remove Chrome Frame tests everywhere. BUG=316496 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=241891

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -60 lines) Patch
M masters/master.chromium.linux/master_gatekeeper_cfg.py View 1 chunk +0 lines, -1 line 0 comments Download
M masters/master.chromium.mac/master_gatekeeper_cfg.py View 1 chunk +0 lines, -1 line 2 comments Download
M masters/master.chromium/master_gatekeeper_cfg.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/master/factory/chromium_commands.py View 1 chunk +0 lines, -6 lines 0 comments Download
M scripts/master/factory/chromium_factory.py View 1 chunk +0 lines, -26 lines 0 comments Download
M scripts/slave/kill_processes.py View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/zip_build.py View 1 chunk +0 lines, -1 line 0 comments Download
M tests/data/trymail_tests/buildrunner_tryserver.expected View 1 chunk +7 lines, -14 lines 0 comments Download
M tests/data/trymail_tests/buildrunner_tryserver.in View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/data/trymail_tests/cq_succeed.in View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
grt (UTC plus 2)
7 years ago (2013-12-18 04:06:05 UTC) #1
M-A Ruel
lgtm, cc'ing one of the trooper which will watch the tree. One of them should ...
7 years ago (2013-12-18 13:16:43 UTC) #2
grt (UTC plus 2)
https://codereview.chromium.org/110373008/diff/20001/masters/master.chromium.mac/master_gatekeeper_cfg.py File masters/master.chromium.mac/master_gatekeeper_cfg.py (left): https://codereview.chromium.org/110373008/diff/20001/masters/master.chromium.mac/master_gatekeeper_cfg.py#oldcode21 masters/master.chromium.mac/master_gatekeeper_cfg.py:21: 'chrome_frame_net_tests', On 2013/12/18 13:16:44, M-A Ruel wrote: > <3 ...
7 years ago (2013-12-18 14:01:21 UTC) #3
Paweł Hajdan Jr.
LGTM
7 years ago (2013-12-18 17:01:11 UTC) #4
grt (UTC plus 2)
Thanks, Paweł. Could you flip the CQ bit and monitor for bustage? On Dec 18, ...
7 years ago (2013-12-18 20:27:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/110373008/20001
7 years ago (2013-12-19 18:32:25 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-19 18:33:45 UTC) #7
Message was sent while issue was closed.
Change committed as 241891

Powered by Google App Engine
This is Rietveld 408576698