Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: scripts/master/factory/chromium_factory.py

Issue 110373008: Remove Chrome Frame tests everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Utility class to build the chromium master BuildFactory's. 5 """Utility class to build the chromium master BuildFactory's.
6 6
7 Based on gclient_factory.py and adds chromium-specific steps.""" 7 Based on gclient_factory.py and adds chromium-specific steps."""
8 8
9 import re 9 import re
10 10
(...skipping 755 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 if R('content_gl_tests'): 766 if R('content_gl_tests'):
767 f.AddContentGLTests(fp) 767 f.AddContentGLTests(fp)
768 if R('gles2_conform_test'): 768 if R('gles2_conform_test'):
769 f.AddGLES2ConformTest(fp) 769 f.AddGLES2ConformTest(fp)
770 if R('gles2_conform_test_br'): 770 if R('gles2_conform_test_br'):
771 f.AddBuildrunnerGTest('gles2_conform_test', fp, 771 f.AddBuildrunnerGTest('gles2_conform_test', fp,
772 test_tool_arg_list=['--no-xvfb']) 772 test_tool_arg_list=['--no-xvfb'])
773 if R('gpu_content_tests'): 773 if R('gpu_content_tests'):
774 f.AddGpuContentTests(fp) 774 f.AddGpuContentTests(fp)
775 775
776 # ChromeFrame tests:
777 if R('chrome_frame_perftests'):
778 f.AddChromeFramePerfTests(fp)
779 if R('chrome_frame'):
780 # Add all major CF tests.
781 f.AddGTestTestStep('chrome_frame_net_tests', fp)
782 f.AddGTestTestStep('chrome_frame_unittests', fp)
783 f.AddGTestTestStep('chrome_frame_tests', fp)
784 elif R('chrome_frame_br'):
785 f.AddBuildrunnerGTest('chrome_frame_net_tests', fp)
786 f.AddBuildrunnerGTest('chrome_frame_unittests', fp)
787 f.AddBuildrunnerGTest('chrome_frame_tests', fp)
788 else:
789 if R('chrome_frame_net_tests'):
790 f.AddGTestTestStep('chrome_frame_net_tests', fp)
791 if R('chrome_frame_net_tests_br'):
792 f.AddBuildrunnerGTest('chrome_frame_net_tests', fp)
793 if R('chrome_frame_unittests'):
794 f.AddGTestTestStep('chrome_frame_unittests', fp)
795 if R('chrome_frame_unittests_br'):
796 f.AddBuildrunnerGTest('chrome_frame_unittests', fp)
797 if R('chrome_frame_tests'):
798 f.AddGTestTestStep('chrome_frame_tests', fp)
799 if R('chrome_frame_tests_br'):
800 f.AddBuildrunnerGTest('chrome_frame_tests', fp)
801
802 def S(test, prefix, add_functor, br_functor=None): 776 def S(test, prefix, add_functor, br_functor=None):
803 """Find any tests with a specific prefix and add them to the build. 777 """Find any tests with a specific prefix and add them to the build.
804 778
805 S() looks for prefix attached to a test, strips the prefix, and performs a 779 S() looks for prefix attached to a test, strips the prefix, and performs a
806 prefix-specific add function via add_functor. If the test is also a 780 prefix-specific add function via add_functor. If the test is also a
807 buildrunner test (ends in _br), it uses a buildrunner functor. Thus, 781 buildrunner test (ends in _br), it uses a buildrunner functor. Thus,
808 instead of ash_unittests, valgrind_ash_unittests is ash_unittests added 782 instead of ash_unittests, valgrind_ash_unittests is ash_unittests added
809 with a special function (one that wraps it with a valgrind driver. 783 with a special function (one that wraps it with a valgrind driver.
810 """ 784 """
811 if test.startswith(prefix): 785 if test.startswith(prefix):
(...skipping 581 matching lines...) Expand 10 before | Expand all | Expand 10 after
1393 mode=None, slave_type='BuilderTester', options=None, 1367 mode=None, slave_type='BuilderTester', options=None,
1394 compile_timeout=1200, build_url=None, project=None, 1368 compile_timeout=1200, build_url=None, project=None,
1395 factory_properties=None): 1369 factory_properties=None):
1396 # Make sure the solution is not already there. 1370 # Make sure the solution is not already there.
1397 if 'cros_deps' not in [s.name for s in self._solutions]: 1371 if 'cros_deps' not in [s.name for s in self._solutions]:
1398 self._solutions.append(gclient_factory.GClientSolution( 1372 self._solutions.append(gclient_factory.GClientSolution(
1399 config.Master.trunk_url + '/src/tools/cros.DEPS', name='cros_deps')) 1373 config.Master.trunk_url + '/src/tools/cros.DEPS', name='cros_deps'))
1400 return self.ChromiumFactory(target, clobber, tests, mode, slave_type, 1374 return self.ChromiumFactory(target, clobber, tests, mode, slave_type,
1401 options, compile_timeout, build_url, project, 1375 options, compile_timeout, build_url, project,
1402 factory_properties) 1376 factory_properties)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698