chrome/browser/ui/webui/help/version_updater_win.cc - Issue 1103713003: win: Move a few WeakPtrFactories to the end of their containing classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/help/version_updater_win.cc

Issue 1103713003: win: Move a few WeakPtrFactories to the end of their containing classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/message_center_notification_manager.cc ('k') | content/child/npapi/webplugin_delegate_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/help/version_updater_win.cc

diff --git a/chrome/browser/ui/webui/help/version_updater_win.cc b/chrome/browser/ui/webui/help/version_updater_win.cc

index 9825fe02ff594e9ff129e41332640258b8937fea..72231676eb6741fb639bfed1939cc84bdf77cbe3 100644

--- a/chrome/browser/ui/webui/help/version_updater_win.cc

+++ b/chrome/browser/ui/webui/help/version_updater_win.cc

@@ -62,12 +62,12 @@ class VersionUpdaterWin : public VersionUpdater {

void BeginUpdateCheckOnFileThread(bool install_if_newer);

- // Used for callbacks.

- base::WeakPtrFactory<VersionUpdaterWin> weak_factory_;

// Callback used to communicate update status to the client.

StatusCallback callback_;

+ // Used for callbacks.

+ base::WeakPtrFactory<VersionUpdaterWin> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(VersionUpdaterWin);

};