Issue 1103683002: Version 4.2.77.18 (cherry-pick)

Issue 1103683002: Version 4.2.77.18 (cherry-pick) (Closed)

Created:
5 years, 8 months ago by Hannes Payer (out of office)

Modified:
5 years, 8 months ago

Reviewers:
rmcilroy

CC:
v8-dev, Paweł Hajdan Jr., ulan

Base URL:
https://chromium.googlesource.com/v8/v8.git@4.2

Target Ref:
refs/pending/branch-heads/4.2

Project:
v8

Visibility:
Public.

More Reviews

Description

Version 4.2.77.18 (cherry-pick) Merged 88e2d14c9038ec177bfa4295aabd9dd9e1d98ac8 Merged c96a2d3a742fe789af64387c4796d7aa0a5a494f Initialize idle old generation allocation limit in constructor. Use smaller heap growing factor in idle notification to start incremental marking when there is idle time >16ms. BUG=478082, chromium:477323 LOG=N R=rmcilroy@chromium.org

Patch Set 1 #

Patch Set 2 : Resolved merge conflict #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -22 lines)			Patch
M	include/v8-version.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap/gc-idle-time-handler.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/heap/heap.h	View	1 2 3	4 chunks	+18 lines, -5 lines	0 comments	Download
M	src/heap/heap.cc	View	1	9 chunks	+38 lines, -15 lines	0 comments	Download
M	src/heap/incremental-marking.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rmcilroy

lgtm, thanks! https://codereview.chromium.org/1103683002/diff/20001/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1103683002/diff/20001/src/heap/heap.h#newcode1616 src/heap/heap.h:1616: // The allocation limit when there is ...

5 years, 8 months ago (2015-04-23 13:39:58 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/1103683002/diff/20001/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1103683002/diff/20001/src/heap/heap.h#newcode1616 src/heap/heap.h:1616: // The allocation limit when there is >16.66ms idle ...

5 years, 8 months ago (2015-04-23 13:51:33 UTC) #3

rmcilroy

5 years, 8 months ago (2015-04-23 14:26:38 UTC) #4

On 2015/04/23 13:51:33, Hannes Payer wrote:
> https://codereview.chromium.org/1103683002/diff/20001/src/heap/heap.h
> File src/heap/heap.h (right):
> 
>
https://codereview.chromium.org/1103683002/diff/20001/src/heap/heap.h#newcode...
> src/heap/heap.h:1616: // The allocation limit when there is >16.66ms idle time
> in the idle time
> On 2015/04/23 13:39:58, rmcilroy wrote:
> > when there is > kMinIdleTimeToStartIncrementalMarking ?
> 
> Done.

still lgtm. Thanks.

Expand Messages | Collapse Messages