Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 11035067: Add loadCommit and loadStop Event (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add LoadStop and LoadCommit Test Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_plugin/browser_plugin_guest.cc
diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc
index b65256c27f1fce7233363df7a66a376a1daa98d8..7ca1ee3ef4065734e1b12bb662405142fc2df329 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.cc
+++ b/content/browser/browser_plugin/browser_plugin_guest.cc
@@ -374,14 +374,22 @@ void BrowserPluginGuest::DidCommitProvisionalLoadForFrame(
PageTransition transition_type,
RenderViewHost* render_view_host) {
// Inform its embedder of the updated URL.
- if (is_main_frame) {
+ SendMessageToEmbedder(
+ new BrowserPluginMsg_LoadCommit(
+ instance_id(),
+ url,
+ render_view_host->GetProcess()->GetID(),
+ is_main_frame));
+ RecordAction(UserMetricsAction("BrowserPlugin.Guest.DidCommit"));
Charlie Reis 2012/10/08 19:03:39 Let's stick with DidNavigate here, since we alread
irobert 2012/10/10 23:55:16 Done.
+}
+
+void BrowserPluginGuest::DidFinishLoad(int64 frame_id,
Charlie Reis 2012/10/08 19:03:39 We should be listening to DidStopLoading rather th
irobert 2012/10/10 23:55:16 Done.
+ const GURL& validated_url,
+ bool is_main_frame,
+ RenderViewHost* render_view_host) {
+ if(is_main_frame)
SendMessageToEmbedder(
- new BrowserPluginMsg_DidNavigate(
- instance_id(),
- url,
- render_view_host->GetProcess()->GetID()));
- RecordAction(UserMetricsAction("BrowserPlugin.Guest.DidNavigate"));
- }
+ new BrowserPluginMsg_LoadStop(instance_id()));
}
void BrowserPluginGuest::RenderViewGone(base::TerminationStatus status) {

Powered by Google App Engine
This is Rietveld 408576698