Add loadCommit and loadStop Event

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <algorithm>
 
 #include "base/string_util.h"
 #include "content/browser/browser_plugin/browser_plugin_guest_helper.h"
@@ skipping 356 matching lines @@
           instance_id(), old_url, new_url, is_top_level));
 }
 
 void BrowserPluginGuest::DidCommitProvisionalLoadForFrame(
     int64 frame_id,
     bool is_main_frame,
     const GURL& url,
     PageTransition transition_type,
     RenderViewHost* render_view_host) {
   // Inform its embedder of the updated URL.
-  if (is_main_frame) {
+  SendMessageToEmbedder(
+      new BrowserPluginMsg_LoadCommit(
+          instance_id(),
+          url,
+          render_view_host->GetProcess()->GetID(),
+          is_main_frame));
+  RecordAction(UserMetricsAction("BrowserPlugin.Guest.DidCommit"));

[Charlie Reis, 2012/10/08 19:03:39]

Let's stick with DidNavigate here, since we already have data collected under
that name.

[irobert, 2012/10/10 23:55:16]

Done.

+}
+
+void BrowserPluginGuest::DidFinishLoad(int64 frame_id,

[Charlie Reis, 2012/10/08 19:03:39]

We should be listening to DidStopLoading rather than DidFinishLoad.

[irobert, 2012/10/10 23:55:16]

Done.

+      const GURL& validated_url,
+      bool is_main_frame,
+      RenderViewHost* render_view_host) {
+  if(is_main_frame)
     SendMessageToEmbedder(
-        new BrowserPluginMsg_DidNavigate(
-            instance_id(),
-            url,
-            render_view_host->GetProcess()->GetID()));
-    RecordAction(UserMetricsAction("BrowserPlugin.Guest.DidNavigate"));
-  }
+        new BrowserPluginMsg_LoadStop(instance_id()));
 }
 
 void BrowserPluginGuest::RenderViewGone(base::TerminationStatus status) {
   if (pending_input_event_reply_.get()) {
     IPC::Message* reply_message = pending_input_event_reply_.release();
     BrowserPluginHostMsg_HandleInputEvent::WriteReplyParams(reply_message,
                                                             false,
                                                             cursor_);
     SendMessageToEmbedder(reply_message);
   }
@@ skipping 18 matching lines @@
       break;
   }
 }
 
 void BrowserPluginGuest::SendMessageToEmbedder(IPC::Message* msg) {
   DCHECK(embedder_render_process_host());
   embedder_render_process_host()->Send(msg);
 }
 
 }  // namespace content