Chromium Code Reviews
Help | Chromium Project | Sign in
(26)

Issue 11035054: Make sure that names of temporaries do not clash with real variables. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by rossberg
Modified:
1 year, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Make sure that names of temporaries do not clash with real variables.


R=mstarzinger@chromium.org
BUG=v8:2322
Committed: https://code.google.com/p/v8/source/detail?r=12668

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adapt debugger test. #

Patch Set 3 : Addressed Michael's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Lint Patch
M include/v8.h View 1 2 1 chunk +1 line, -1 line 0 comments 0 errors Download
M src/heap.h View 1 2 1 chunk +1 line, -0 lines 0 comments ? errors Download
M src/parser.cc View 1 chunk +6 lines, -1 line 0 comments ? errors Download
M src/scopes.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M test/mjsunit/harmony/debug-blockscopes.js View 1 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M test/mjsunit/regress/regress-2322.js View 1 chunk +5 lines, -0 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 3
rossberg
1 year, 6 months ago #1
Michael Starzinger
LGTM (with comments). https://codereview.chromium.org/11035054/diff/1/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/11035054/diff/1/src/parser.cc#newcode2847 src/parser.cc:2847: heap_factory->NewStringFromAscii(CStrVector(".for.")); You could move this symbol ...
1 year, 6 months ago #2
rossberg
1 year, 6 months ago #3
https://codereview.chromium.org/11035054/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/11035054/diff/1/src/parser.cc#newcode2847
src/parser.cc:2847: heap_factory->NewStringFromAscii(CStrVector(".for."));
On 2012/10/05 12:31:38, Michael Starzinger wrote:
> You could move this symbol into the root-set by adding it to SYMBOL_LIST, call
> it e.g. dot_for_symbol and then access it through factory->dot_for_symbol().

Done.

> Also does the name really need to be different for every temporary, or could
we
> use the one symbol for all temporaries?

There can be several loop variables in the same scope, so they should be
distinguishable.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6