Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: lib/compiler/implementation/constants.dart

Issue 11033016: Added TODO. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/constants.dart
diff --git a/lib/compiler/implementation/constants.dart b/lib/compiler/implementation/constants.dart
index ae53658441ee623af04b33174e4492b1c37a3e7f..73aa967473eadbec0a250216dca75344a7f45a38 100644
--- a/lib/compiler/implementation/constants.dart
+++ b/lib/compiler/implementation/constants.dart
@@ -16,7 +16,7 @@ abstract class ConstantVisitor<R> {
R visitConstructed(ConstructedConstant constant);
}
-class Constant {
+abstract class Constant {
const Constant();
bool isNull() => false;
@@ -88,7 +88,7 @@ class FunctionConstant extends Constant {
accept(ConstantVisitor visitor) => visitor.visitFunction(this);
}
-class PrimitiveConstant extends Constant {
+abstract class PrimitiveConstant extends Constant {
abstract get value;
const PrimitiveConstant();
bool isPrimitive() => true;
@@ -130,7 +130,7 @@ class NullConstant extends PrimitiveConstant {
accept(ConstantVisitor visitor) => visitor.visitNull(this);
}
-class NumConstant extends PrimitiveConstant {
+abstract class NumConstant extends PrimitiveConstant {
abstract num get value;
const NumConstant();
bool isNum() => true;
@@ -225,7 +225,7 @@ class DoubleConstant extends NumConstant {
accept(ConstantVisitor visitor) => visitor.visitDouble(this);
}
-class BoolConstant extends PrimitiveConstant {
+abstract class BoolConstant extends PrimitiveConstant {
factory BoolConstant(value) {
return value ? new TrueConstant() : new FalseConstant();
}
@@ -305,7 +305,7 @@ class StringConstant extends PrimitiveConstant {
accept(ConstantVisitor visitor) => visitor.visitString(this);
}
-class ObjectConstant extends Constant {
+abstract class ObjectConstant extends Constant {
final DartType type;
ObjectConstant(this.type);
« no previous file with comments | « lib/compiler/implementation/constant_system_dart.dart ('k') | lib/compiler/implementation/dart_backend/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698