Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: lib/compiler/implementation/constant_system_dart.dart

Issue 11033016: Added TODO. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/compiler.dart ('k') | lib/compiler/implementation/constants.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/constant_system_dart.dart
diff --git a/lib/compiler/implementation/constant_system_dart.dart b/lib/compiler/implementation/constant_system_dart.dart
index 56b1663cf53cc87e26aab44c82fc9e9e566e879e..2d9943724bf09efb3352fbdfb8c25b6403d12c48 100644
--- a/lib/compiler/implementation/constant_system_dart.dart
+++ b/lib/compiler/implementation/constant_system_dart.dart
@@ -53,7 +53,7 @@ class NotOperation implements UnaryOperation {
/**
* Operations that only work if both arguments are integers.
*/
-class BinaryBitOperation implements BinaryOperation {
+abstract class BinaryBitOperation implements BinaryOperation {
bool isUserDefinable() => true;
const BinaryBitOperation();
Constant fold(Constant left, Constant right) {
@@ -113,7 +113,7 @@ class ShiftRightOperation extends BinaryBitOperation {
apply(left, right) => left >> right;
}
-class BinaryBoolOperation implements BinaryOperation {
+abstract class BinaryBoolOperation implements BinaryOperation {
bool isUserDefinable() => false;
const BinaryBoolOperation();
Constant fold(Constant left, Constant right) {
@@ -143,7 +143,7 @@ class BooleanOrOperation extends BinaryBoolOperation {
apply(left, right) => left || right;
}
-class ArithmeticNumOperation implements BinaryOperation {
+abstract class ArithmeticNumOperation implements BinaryOperation {
bool isUserDefinable() => true;
const ArithmeticNumOperation();
Constant fold(Constant left, Constant right) {
@@ -239,7 +239,7 @@ class AddOperation implements BinaryOperation {
apply(left, right) => left + right;
}
-class RelationalNumOperation implements BinaryOperation {
+abstract class RelationalNumOperation implements BinaryOperation {
bool isUserDefinable() => true;
const RelationalNumOperation();
Constant fold(Constant left, Constant right) {
« no previous file with comments | « lib/compiler/implementation/compiler.dart ('k') | lib/compiler/implementation/constants.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698