Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1103293003: Remove ICS support code in chrome/ and components/precache/ (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
Reviewers:
bengr, newt (away)
CC:
asvitkine+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, mlamouri+watch-notifications_chromium.org, peter+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ICS support code in chrome/ and components/precache/ BUG=473837, 431717 TBR=bengr@chromium.org Committed: https://crrev.com/acb0e1da5a1bec89c8ce40101641c3e8aa4ba60c Cr-Commit-Position: refs/heads/master@{#327192}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unused constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -43 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java View 1 4 chunks +1 line, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/AnimationHelper.java View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/remote/LockScreenTransportControl.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/metrics/MemoryUma.java View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationUIManagerTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/WebsiteAddressTest.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M components/precache/android/java/src/org/chromium/components/precache/NetworkInfoDelegate.java View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
aurimas (slooooooooow)
PTAL
5 years, 8 months ago (2015-04-27 21:07:23 UTC) #2
newt (away)
https://chromiumcodereview.appspot.com/1103293003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java File chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java (left): https://chromiumcodereview.appspot.com/1103293003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java#oldcode512 chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java:512: if (!mHandler.hasMessages(MSG_ID_CONTROLS_REQUEST_LAYOUT)) { MSG_ID_CONTROLS_REQUEST_LAYOUT isn't sent anymore. It should ...
5 years, 8 months ago (2015-04-27 21:23:32 UTC) #3
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/1103293003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java File chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java (left): https://chromiumcodereview.appspot.com/1103293003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java#oldcode512 chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java:512: if (!mHandler.hasMessages(MSG_ID_CONTROLS_REQUEST_LAYOUT)) { On 2015/04/27 at 21:23:32, newt wrote: ...
5 years, 8 months ago (2015-04-27 22:28:12 UTC) #5
bengr
lgtm
5 years, 8 months ago (2015-04-27 22:29:48 UTC) #6
newt (away)
lgtm
5 years, 8 months ago (2015-04-27 23:45:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103293003/20001
5 years, 8 months ago (2015-04-27 23:51:05 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-28 00:29:24 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-28 00:31:02 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/acb0e1da5a1bec89c8ce40101641c3e8aa4ba60c
Cr-Commit-Position: refs/heads/master@{#327192}

Powered by Google App Engine
This is Rietveld 408576698