Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4677)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java

Issue 1103293003: Remove ICS support code in chrome/ and components/precache/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused constant Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java b/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
index 73e7ef0072a9b4a23ca9571c75def3eb2599b32e..ba1021c6c64a4be58282cf76c243ad132f0c289c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
@@ -9,7 +9,6 @@ import android.animation.AnimatorListenerAdapter;
import android.animation.ObjectAnimator;
import android.app.Activity;
import android.content.res.Resources;
-import android.os.Build;
import android.os.Handler;
import android.os.Message;
import android.os.SystemClock;
@@ -51,8 +50,7 @@ public class ChromeFullscreenManager
// Maximum length of the slide in/out animation of the toolbar (in ms).
private static final long MAX_ANIMATION_DURATION_MS = 500;
- private static final int MSG_ID_CONTROLS_REQUEST_LAYOUT = 1;
- private static final int MSG_ID_HIDE_CONTROLS = 2;
+ private static final int MSG_ID_HIDE_CONTROLS = 1;
private final HashSet<Integer> mPersistentControlTokens = new HashSet<Integer>();
@@ -166,9 +164,6 @@ public class ChromeFullscreenManager
ChromeFullscreenManager chromeFullscreenManager = mChromeFullscreenManager.get();
if (chromeFullscreenManager == null) return;
switch (msg.what) {
- case MSG_ID_CONTROLS_REQUEST_LAYOUT:
- chromeFullscreenManager.mControlContainer.requestLayout();
- break;
case MSG_ID_HIDE_CONTROLS:
chromeFullscreenManager.update(false);
break;
@@ -505,14 +500,6 @@ public class ChromeFullscreenManager
scheduleVisibilityUpdate();
if (shouldShowAndroidControls()) mControlContainer.setTranslationY(getControlOffset());
- // In ICS, the toolbar can appear clipped when compositor content is not being drawn
- // beneath it (at the top of the page, during side swipe). Requesting a layout clears
- // up the issue (see crbug.com/172631).
- if (Build.VERSION.SDK_INT < Build.VERSION_CODES.JELLY_BEAN) {
- if (!mHandler.hasMessages(MSG_ID_CONTROLS_REQUEST_LAYOUT)) {
- mHandler.sendEmptyMessage(MSG_ID_CONTROLS_REQUEST_LAYOUT);
- }
- }
for (int i = 0; i < mListeners.size(); i++) {
mListeners.get(i).onVisibleContentOffsetChanged(getVisibleContentOffset());
}

Powered by Google App Engine
This is Rietveld 408576698