Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1103273002: Remove protected-access from tools/perf/pylintrc. (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove protected-access from tools/perf/pylintrc. BUG=475714 Committed: https://crrev.com/3a9c76bf2d3619c50c244b26c8d67daf32201c66 Cr-Commit-Position: refs/heads/master@{#327078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M tools/perf/benchmarks/page_cycler.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/measurements/oilpan_gc_times_unittest.py View 3 chunks +4 lines, -1 line 0 comments Download
M tools/perf/measurements/task_execution_time_unittest.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/perf/measurements/v8_gc_times.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/measurements/v8_gc_times_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/pylintrc View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/update_reference_build_unittest.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
5 years, 7 months ago (2015-04-27 17:25:57 UTC) #2
sullivan
lgtm
5 years, 7 months ago (2015-04-27 17:27:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103273002/1
5 years, 7 months ago (2015-04-27 17:29:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-27 18:29:13 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 18:30:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a9c76bf2d3619c50c244b26c8d67daf32201c66
Cr-Commit-Position: refs/heads/master@{#327078}

Powered by Google App Engine
This is Rietveld 408576698