Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: tools/perf/measurements/v8_gc_times_unittest.py

Issue 1103273002: Remove protected-access from tools/perf/pylintrc. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/measurements/v8_gc_times.py ('k') | tools/perf/pylintrc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.core import wpr_modes 5 from telemetry.core import wpr_modes
6 from telemetry.page import page as page_module 6 from telemetry.page import page as page_module
7 from telemetry.results import page_test_results 7 from telemetry.results import page_test_results
8 from telemetry.timeline import model as model_module 8 from telemetry.timeline import model as model_module
9 from telemetry.unittest_util import options_for_unittests 9 from telemetry.unittest_util import options_for_unittests
10 from telemetry.unittest_util import page_test_test_case 10 from telemetry.unittest_util import page_test_test_case
(...skipping 28 matching lines...) Expand all
39 def MeasureFakePage(self): 39 def MeasureFakePage(self):
40 # Create a fake page and add it to the page set. 40 # Create a fake page and add it to the page set.
41 results = page_test_results.PageTestResults() 41 results = page_test_results.PageTestResults()
42 page = V8GCTimesTestPageHelper.MockV8GCTimesPage(self._page_set) 42 page = V8GCTimesTestPageHelper.MockV8GCTimesPage(self._page_set)
43 self._page_set.AddUserStory(page) 43 self._page_set.AddUserStory(page)
44 44
45 # Pretend we're about to run the tests to silence lower level asserts. 45 # Pretend we're about to run the tests to silence lower level asserts.
46 results.WillRunPage(page) 46 results.WillRunPage(page)
47 47
48 v8_gc_times_metric = v8_gc_times.V8GCTimes() 48 v8_gc_times_metric = v8_gc_times.V8GCTimes()
49 # pylint: disable=protected-access
49 v8_gc_times_metric._renderer_process = self._renderer_process 50 v8_gc_times_metric._renderer_process = self._renderer_process
50 51
51 # Finalize the timeline import. 52 # Finalize the timeline import.
52 self._model.FinalizeImport() 53 self._model.FinalizeImport()
53 54
54 # Measure the V8GCTimes metric and return the results 55 # Measure the V8GCTimes metric and return the results
55 v8_gc_times_metric.ValidateAndMeasurePage(page, None, results) 56 v8_gc_times_metric.ValidateAndMeasurePage(page, None, results)
56 results.DidRunPage(page) 57 results.DidRunPage(page)
57 return results 58 return results
58 59
(...skipping 196 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 'v8_gc_mark_compactor_idle_deadline_overrun': ('ms', 0.0), 256 'v8_gc_mark_compactor_idle_deadline_overrun': ('ms', 0.0),
256 'v8_gc_mark_compactor_outside_idle': ('ms', 0.0), 257 'v8_gc_mark_compactor_outside_idle': ('ms', 0.0),
257 'v8_gc_mark_compactor_percentage_idle': ('idle%', 0.0), 258 'v8_gc_mark_compactor_percentage_idle': ('idle%', 0.0),
258 'v8_gc_scavenger': ('ms', 0.0), 259 'v8_gc_scavenger': ('ms', 0.0),
259 'v8_gc_scavenger_idle_deadline_overrun': ('ms', 0.0), 260 'v8_gc_scavenger_idle_deadline_overrun': ('ms', 0.0),
260 'v8_gc_scavenger_outside_idle': ('ms', 0.0), 261 'v8_gc_scavenger_outside_idle': ('ms', 0.0),
261 'v8_gc_scavenger_percentage_idle': ('idle%', 0.0), 262 'v8_gc_scavenger_percentage_idle': ('idle%', 0.0),
262 'v8_gc_total': ('ms', 0.0), 263 'v8_gc_total': ('ms', 0.0),
263 'v8_gc_total_idle_deadline_overrun': ('ms', 0.0), 264 'v8_gc_total_idle_deadline_overrun': ('ms', 0.0),
264 'v8_gc_total_outside_idle': ('ms', 0.0)} 265 'v8_gc_total_outside_idle': ('ms', 0.0)}
OLDNEW
« no previous file with comments | « tools/perf/measurements/v8_gc_times.py ('k') | tools/perf/pylintrc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698