Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: ui/events/keycodes/keyboard_code_conversion.h

Issue 1103263004: Set ui::KeyEvent::key_ (DOM Level 3 key) under X11. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/keycodes/keyboard_code_conversion.h
diff --git a/ui/events/keycodes/keyboard_code_conversion.h b/ui/events/keycodes/keyboard_code_conversion.h
index 8b92ba16394eaaebd48ccbacd86bed3ec453bc99..c312710b8be1f3dafee726c6e8a377d924083aad 100644
--- a/ui/events/keycodes/keyboard_code_conversion.h
+++ b/ui/events/keycodes/keyboard_code_conversion.h
@@ -70,6 +70,11 @@ EVENTS_BASE_EXPORT bool DomCodeToControlCharacter(DomCode dom_code,
KeyboardCode* key_code)
WARN_UNUSED_RESULT;
+// Returns the DomKey value associated with an ASCII/Unicode character.
+// All printable characters and most other character codes use
+// DomKey::CHARACTER, but a few ASCII C0 codes have their own DomKey.
+EVENTS_BASE_EXPORT DomKey CharacterToDomKey(base::char16 character);
Wez 2015/05/06 23:51:53 nit: Using char16 here means we're limited to UCS2
kpschoedel 2015/05/07 16:21:33 Done.
+
// Returns a Windows-based VKEY for a non-printable DOM Level 3 |key|.
// The returned VKEY is non-located (e.g. VKEY_SHIFT).
EVENTS_BASE_EXPORT KeyboardCode

Powered by Google App Engine
This is Rietveld 408576698