Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: ui/events/keycodes/keyboard_code_conversion.cc

Issue 1103263004: Set ui::KeyEvent::key_ (DOM Level 3 key) under X11. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/keycodes/keyboard_code_conversion.cc
diff --git a/ui/events/keycodes/keyboard_code_conversion.cc b/ui/events/keycodes/keyboard_code_conversion.cc
index e31512b8c5e90efa0e642faead98db3f4f8cbf52..0a967b912fa97d2bef955b85924bb1e35f8d2c3d 100644
--- a/ui/events/keycodes/keyboard_code_conversion.cc
+++ b/ui/events/keycodes/keyboard_code_conversion.cc
@@ -428,6 +428,22 @@ bool DomCodeToControlCharacter(DomCode dom_code,
}
}
+DomKey CharacterToDomKey(base::char16 character) {
+ switch (character) {
+ case 0x08:
+ return DomKey::BACKSPACE;
+ case 0x09:
+ return DomKey::TAB;
+ case 0x0A:
+ case 0x0D:
Wez 2015/05/06 23:51:53 Do we really want to map both of these to Enter? T
kpschoedel 2015/05/07 16:21:33 Done.
+ return DomKey::ENTER;
+ case 0x1B:
+ return DomKey::ESCAPE;
+ default:
+ return DomKey::CHARACTER;
+ }
+}
+
// Returns a Windows-based VKEY for a non-printable DOM Level 3 |key|.
// The returned VKEY is non-positional (e.g. VKEY_SHIFT).
KeyboardCode NonPrintableDomKeyToKeyboardCode(DomKey dom_key) {

Powered by Google App Engine
This is Rietveld 408576698