Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: tools/test.dart

Issue 11032047: Fix issues with test.dart that appeared on Mac. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/testing/dart/http_server.dart » ('j') | tools/testing/dart/test_progress.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/test.dart
diff --git a/tools/test.dart b/tools/test.dart
index 869d879fb684e09e851a092cc7c2a60e8237fbd5..439aaad6592839c1b382136b0c190fc78a414a6b 100755
--- a/tools/test.dart
+++ b/tools/test.dart
@@ -127,32 +127,17 @@ main() {
// Start global http server that serves the entire dart repo.
// The http server is available on localhost:9876 for any
// test that needs to load resources from the repo over http.
- //
- // TODO(ager): Simplify when mac os startHttpServer issues has
- // been resolved.
- if (!listTests) {
- startHttpServer('127.0.0.1', 9876).then((_) {
- // Start process queue.
- new ProcessQueue(maxProcesses,
- progressIndicator,
- startTime,
- printTiming,
- enqueueConfiguration,
- () {
- if (!listTests) terminateHttpServer();
- },
- verbose,
- listTests);
- });
- } else {
- // Start process queue.
- new ProcessQueue(maxProcesses,
- progressIndicator,
- startTime,
- printTiming,
- enqueueConfiguration,
- () => null,
- verbose,
- listTests);
- }
+ if (!listTests) startHttpServer('127.0.0.1', 9876);
+
+ // Start process queue.
+ new ProcessQueue(maxProcesses,
+ progressIndicator,
+ startTime,
+ printTiming,
+ enqueueConfiguration,
+ () {
+ if (!listTests) terminateHttpServer();
+ },
+ verbose,
+ listTests);
}
« no previous file with comments | « no previous file | tools/testing/dart/http_server.dart » ('j') | tools/testing/dart/test_progress.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698