Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1103173004: Remove WasChannelIDSent and friends from SSLClientSocket. (Closed)

Created:
5 years, 7 months ago by davidben
Modified:
5 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@virtuals-wat-1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WasChannelIDSent and friends from SSLClientSocket. It's redundant with the bit in GetSSLInfo and state already maintained by the SSLClientSocket implementations. BUG=477847 Committed: https://crrev.com/52053b38952b82f391d40e455cadaa3d5b213d88 Cr-Commit-Position: refs/heads/master@{#327101}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -43 lines) Patch
M net/socket/socket_test_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M net/socket/ssl_client_socket.h View 2 chunks +0 lines, -12 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/socket/ssl_client_socket_openssl.h View 1 chunk +2 lines, -2 lines 1 comment Download
M net/socket/ssl_client_socket_openssl.cc View 6 chunks +5 lines, -7 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
https://codereview.chromium.org/1103173004/diff/1/net/socket/ssl_client_socket_openssl.h File net/socket/ssl_client_socket_openssl.h (right): https://codereview.chromium.org/1103173004/diff/1/net/socket/ssl_client_socket_openssl.h#newcode294 net/socket/ssl_client_socket_openssl.h:294: bool channel_id_sent_; Note: It's not possible to negotiate the ...
5 years, 7 months ago (2015-04-27 18:29:39 UTC) #2
Ryan Sleevi
lgtm
5 years, 7 months ago (2015-04-27 18:48:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103173004/1
5 years, 7 months ago (2015-04-27 19:18:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-27 19:22:42 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-27 19:24:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52053b38952b82f391d40e455cadaa3d5b213d88
Cr-Commit-Position: refs/heads/master@{#327101}

Powered by Google App Engine
This is Rietveld 408576698