Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1103173002: deprecate non-phantom weak callbacks (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 7 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland: deprecate non-phantom weak callbacks BUG= Committed: https://crrev.com/3be656fb55ad49834ec8ec0a57ba858bb1b21f37 Cr-Commit-Position: refs/heads/master@{#28094}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M include/v8.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-27 12:30:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103173002/1
5 years, 8 months ago (2015-04-27 12:31:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-27 13:06:50 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/39c31da2142ab0fca9dae279b9e59cd4951a1982 Cr-Commit-Position: refs/heads/master@{#28077}
5 years, 8 months ago (2015-04-27 13:07:00 UTC) #6
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1104163002/ by machenbach@chromium.org. ...
5 years, 8 months ago (2015-04-27 13:30:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1103173002/1
5 years, 7 months ago (2015-04-28 08:31:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 08:31:54 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3be656fb55ad49834ec8ec0a57ba858bb1b21f37 Cr-Commit-Position: refs/heads/master@{#28094}
5 years, 7 months ago (2015-04-28 08:32:08 UTC) #11
Michael Achenbach
5 years, 7 months ago (2015-04-29 05:56:37 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1117623002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] This is still used and now blocks the
roll here:
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp....

Powered by Google App Engine
This is Rietveld 408576698