include/v8.h - Issue 1103173002: deprecate non-phantom weak callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 1103173002: deprecate non-phantom weak callbacks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/v8.h

diff --git a/include/v8.h b/include/v8.h

index bca6bf1b6fd1c99f762ec307452661e0477d2300..dd3fa51f178773666bfaea8e21b797641f4bf053 100644

--- a/include/v8.h

+++ b/include/v8.h

@@ -542,13 +542,13 @@ template <class T> class PersistentBase {

* critical form of resource management!

template <typename P>

- V8_INLINE V8_DEPRECATE_SOON(

+ V8_INLINE V8_DEPRECATED(

"use WeakCallbackInfo version",

void SetWeak(P* parameter,

typename WeakCallbackData<T, P>::Callback callback));

template <typename S, typename P>

- V8_INLINE V8_DEPRECATE_SOON(

+ V8_INLINE V8_DEPRECATED(

"use WeakCallbackInfo version",

void SetWeak(P* parameter,

typename WeakCallbackData<S, P>::Callback callback));

@@ -560,7 +560,7 @@ template <class T> class PersistentBase {

// specify a parameter for the callback or the location of two internal

// fields in the dying object.

template <typename P>

- V8_INLINE V8_DEPRECATE_SOON(

+ V8_INLINE V8_DEPRECATED(

"use SetWeak",

void SetPhantom(P* parameter,

typename WeakCallbackInfo<P>::Callback callback,

« no previous file with comments | « no previous file | no next file » | no next file with comments »