Move user_story.user_story_runner to story.story_runner.

Move user_story.user_story_runner to story.story_runner.

BUG=465594
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Committed: https://crrev.com/1f2a81e9697abb10ee9448468a2cad823e6066be
Cr-Commit-Position: refs/heads/master@{#327990}

[aiolos (Not reviewing), 2015-04-30 17:25:49]

aiolos@chromium.org changed reviewers:
+ dtu@chromium.org, nednguyen@google.com

[nednguyen, 2015-04-30 17:45:09]

On 2015/04/30 17:26:38, aiolos wrote:

What about story.runner?

[aiolos (Not reviewing), 2015-04-30 18:00:13]

On 2015/04/30 17:45:09, nednguyen wrote:
> On 2015/04/30 17:26:38, aiolos wrote:
> 
> What about story.runner?

My thought was to avoid confusion between story_runner and benchmark_runner. It
would be especially easy to get confused reading through the code in
benchmark.py since we user story_runner, but not benchmark_runner. And knowing
that both files existed, it would be easy to assume that "runner" referred to
the benchmark runner instead of the story_runner. But I don't feel strongly
about it.

[nednguyen, 2015-04-30 18:26:47]

On 2015/04/30 18:00:13, aiolos wrote:
> On 2015/04/30 17:45:09, nednguyen wrote:
> > On 2015/04/30 17:26:38, aiolos wrote:
> > 
> > What about story.runner?
> 
> My thought was to avoid confusion between story_runner and benchmark_runner.
It
> would be especially easy to get confused reading through the code in
> benchmark.py since we user story_runner, but not benchmark_runner. And knowing
> that both files existed, it would be easy to assume that "runner" referred to
> the benchmark runner instead of the story_runner. But I don't feel strongly
> about it.

We can always do: "from story import runner as story_runner" to avoid confusion.
By default, the fact that runner belong to story package should be enough to
distinguish.

[aiolos (Not reviewing), 2015-04-30 22:00:08]

On 2015/04/30 18:26:47, nednguyen wrote:
> On 2015/04/30 18:00:13, aiolos wrote:
> > On 2015/04/30 17:45:09, nednguyen wrote:
> > > On 2015/04/30 17:26:38, aiolos wrote:
> > > 
> > > What about story.runner?
> > 
> > My thought was to avoid confusion between story_runner and benchmark_runner.
> It
> > would be especially easy to get confused reading through the code in
> > benchmark.py since we user story_runner, but not benchmark_runner. And
knowing
> > that both files existed, it would be easy to assume that "runner" referred
to
> > the benchmark runner instead of the story_runner. But I don't feel strongly
> > about it.
> 
> We can always do: "from story import runner as story_runner" to avoid
confusion.
> By default, the fact that runner belong to story package should be enough to
> distinguish.

ptal

[dtu, 2015-04-30 22:01:15]

On 2015/04/30 18:26:47, nednguyen wrote:
> On 2015/04/30 18:00:13, aiolos wrote:
> > On 2015/04/30 17:45:09, nednguyen wrote:
> > > On 2015/04/30 17:26:38, aiolos wrote:
> > > 
> > > What about story.runner?
> > 
> > My thought was to avoid confusion between story_runner and benchmark_runner.
> It
> > would be especially easy to get confused reading through the code in
> > benchmark.py since we user story_runner, but not benchmark_runner. And
knowing
> > that both files existed, it would be easy to assume that "runner" referred
to
> > the benchmark runner instead of the story_runner. But I don't feel strongly
> > about it.
> 
> We can always do: "from story import runner as story_runner" to avoid
confusion.
> By default, the fact that runner belong to story package should be enough to
> distinguish.

I thought we want to have the story/__init__.py include "from
telemetry.story.runner import *"

Then you reference it as:
from telemetry import story
story.runner

[aiolos (Not reviewing), 2015-04-30 22:02:48]

On 2015/04/30 22:00:08, aiolos wrote:
> On 2015/04/30 18:26:47, nednguyen wrote:
> > On 2015/04/30 18:00:13, aiolos wrote:
> > > On 2015/04/30 17:45:09, nednguyen wrote:
> > > > On 2015/04/30 17:26:38, aiolos wrote:
> > > > 
> > > > What about story.runner?
> > > 
> > > My thought was to avoid confusion between story_runner and
benchmark_runner.
> > It
> > > would be especially easy to get confused reading through the code in
> > > benchmark.py since we user story_runner, but not benchmark_runner. And
> knowing
> > > that both files existed, it would be easy to assume that "runner" referred
> to
> > > the benchmark runner instead of the story_runner. But I don't feel
strongly
> > > about it.
> > 
> > We can always do: "from story import runner as story_runner" to avoid
> confusion.
> > By default, the fact that runner belong to story package should be enough to
> > distinguish.
> 
> ptal

Forgot to move story_runner.py to runner.py. Fixing.

[nednguyen, 2015-04-30 22:11:17]

On 2015/04/30 22:01:15, dtu wrote:
> On 2015/04/30 18:26:47, nednguyen wrote:
> > On 2015/04/30 18:00:13, aiolos wrote:
> > > On 2015/04/30 17:45:09, nednguyen wrote:
> > > > On 2015/04/30 17:26:38, aiolos wrote:
> > > > 
> > > > What about story.runner?
> > > 
> > > My thought was to avoid confusion between story_runner and
benchmark_runner.
> > It
> > > would be especially easy to get confused reading through the code in
> > > benchmark.py since we user story_runner, but not benchmark_runner. And
> knowing
> > > that both files existed, it would be easy to assume that "runner" referred
> to
> > > the benchmark runner instead of the story_runner. But I don't feel
strongly
> > > about it.
> > 
> > We can always do: "from story import runner as story_runner" to avoid
> confusion.
> > By default, the fact that runner belong to story package should be enough to
> > distinguish.
> 
> I thought we want to have the story/__init__.py include "from
> telemetry.story.runner import *"
> 
> Then you reference it as:
> from telemetry import story
> story.runner

Yeah, I forgot to mention this. Actually, it should be:

story/__init__.py
from .story import Story
from .runner import Run
from .runner import CommandlineArgument


And the reference is:

from telemetry import story

story.Run(...)

[aiolos (Not reviewing), 2015-04-30 22:35:49]

On 2015/04/30 22:11:17, nednguyen wrote:
> On 2015/04/30 22:01:15, dtu wrote:
> > On 2015/04/30 18:26:47, nednguyen wrote:
> > > On 2015/04/30 18:00:13, aiolos wrote:
> > > > On 2015/04/30 17:45:09, nednguyen wrote:
> > > > > On 2015/04/30 17:26:38, aiolos wrote:
> > > > > 
> > > > > What about story.runner?
> > > > 
> > > > My thought was to avoid confusion between story_runner and
> benchmark_runner.
> > > It
> > > > would be especially easy to get confused reading through the code in
> > > > benchmark.py since we user story_runner, but not benchmark_runner. And
> > knowing
> > > > that both files existed, it would be easy to assume that "runner"
referred
> > to
> > > > the benchmark runner instead of the story_runner. But I don't feel
> strongly
> > > > about it.
> > > 
> > > We can always do: "from story import runner as story_runner" to avoid
> > confusion.
> > > By default, the fact that runner belong to story package should be enough
to
> > > distinguish.
> > 
> > I thought we want to have the story/__init__.py include "from
> > telemetry.story.runner import *"
> > 
> > Then you reference it as:
> > from telemetry import story
> > story.runner
> 
> Yeah, I forgot to mention this. Actually, it should be:
> 
> story/__init__.py
> from .story import Story
> from .runner import Run
> from .runner import CommandlineArgument
> 
> 
> And the reference is:
> 
> from telemetry import story
> 
> story.Run(...)

Wait. This shouldn't even be here. This should be internal.

[aiolos (Not reviewing), 2015-04-30 22:38:30]

On 2015/04/30 22:35:49, aiolos wrote:
> On 2015/04/30 22:11:17, nednguyen wrote:
> > On 2015/04/30 22:01:15, dtu wrote:
> > > On 2015/04/30 18:26:47, nednguyen wrote:
> > > > On 2015/04/30 18:00:13, aiolos wrote:
> > > > > On 2015/04/30 17:45:09, nednguyen wrote:
> > > > > > On 2015/04/30 17:26:38, aiolos wrote:
> > > > > > 
> > > > > > What about story.runner?
> > > > > 
> > > > > My thought was to avoid confusion between story_runner and
> > benchmark_runner.
> > > > It
> > > > > would be especially easy to get confused reading through the code in
> > > > > benchmark.py since we user story_runner, but not benchmark_runner. And
> > > knowing
> > > > > that both files existed, it would be easy to assume that "runner"
> referred
> > > to
> > > > > the benchmark runner instead of the story_runner. But I don't feel
> > strongly
> > > > > about it.
> > > > 
> > > > We can always do: "from story import runner as story_runner" to avoid
> > > confusion.
> > > > By default, the fact that runner belong to story package should be
enough
> to
> > > > distinguish.
> > > 
> > > I thought we want to have the story/__init__.py include "from
> > > telemetry.story.runner import *"
> > > 
> > > Then you reference it as:
> > > from telemetry import story
> > > story.runner
> > 
> > Yeah, I forgot to mention this. Actually, it should be:
> > 
> > story/__init__.py
> > from .story import Story
> > from .runner import Run
> > from .runner import CommandlineArgument
> > 
> > 
> > And the reference is:
> > 
> > from telemetry import story
> > 
> > story.Run(...)
> 
> Wait. This shouldn't even be here. This should be internal.

(I do agree that the above should be done for things like story.shared_state
though.)

[dtu, 2015-04-30 23:20:33]

lgtm

[nednguyen, 2015-05-01 01:00:29]

lgtm

[aiolos (Not reviewing), 2015-05-01 18:08:14]

The CQ bit was checked by aiolos@chromium.org

[commit-bot: I haz the power, 2015-05-01 18:09:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1103163008/40001

[commit-bot: I haz the power, 2015-05-01 22:00:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-01 22:01:55]

Patchset 3 (id:??) landed as
https://crrev.com/1f2a81e9697abb10ee9448468a2cad823e6066be
Cr-Commit-Position: refs/heads/master@{#327990}