Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: tools/telemetry/telemetry/benchmark_unittest.py

Issue 1103163008: Move user_story.user_story_runner to story.story_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move to internal, not story. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/benchmark.py ('k') | tools/telemetry/telemetry/internal/story_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/benchmark_unittest.py
diff --git a/tools/telemetry/telemetry/benchmark_unittest.py b/tools/telemetry/telemetry/benchmark_unittest.py
index 70212a2ff213b5252515ffdc9240343fcf68e8f8..7c815618901ae47ce0ad3cfe8b19b09159a43353 100644
--- a/tools/telemetry/telemetry/benchmark_unittest.py
+++ b/tools/telemetry/telemetry/benchmark_unittest.py
@@ -7,13 +7,13 @@ import unittest
from telemetry import benchmark
from telemetry.core import browser_options
+from telemetry.internal import story_runner
from telemetry import page
from telemetry.page import page_test
from telemetry.page import shared_page_state
from telemetry.story import shared_state
from telemetry import user_story
from telemetry.user_story import android
-from telemetry.user_story import user_story_runner
from telemetry.user_story import user_story_set as user_story_set_module
from telemetry.web_perf import timeline_based_measurement
@@ -58,11 +58,11 @@ class BenchmarkTest(unittest.TestCase):
b.Run(browser_options.BrowserFinderOptions())
def testPageTestWithCompatibleUserStory(self):
- original_run_fn = user_story_runner.Run
+ original_run_fn = story_runner.Run
was_run = [False]
def RunStub(*_arg, **_kwargs):
was_run[0] = True
- user_story_runner.Run = RunStub
+ story_runner.Run = RunStub
try:
options = browser_options.BrowserFinderOptions()
@@ -75,7 +75,7 @@ class BenchmarkTest(unittest.TestCase):
b = TestBenchmark(page.Page(url='about:blank'))
b.Run(options)
finally:
- user_story_runner.Run = original_run_fn
+ story_runner.Run = original_run_fn
self.assertTrue(was_run[0])
@@ -135,7 +135,7 @@ class BenchmarkTest(unittest.TestCase):
def ValueCanBeAddedPredicate(cls, value, is_first_result):
return False
- original_run_fn = user_story_runner.Run
+ original_run_fn = story_runner.Run
validPredicate = [False]
def RunStub(test, user_story_set, expectations, finder_options, results,
@@ -144,7 +144,7 @@ class BenchmarkTest(unittest.TestCase):
valid = predicate == PredicateBenchmark.ValueCanBeAddedPredicate
validPredicate[0] = valid
- user_story_runner.Run = RunStub
+ story_runner.Run = RunStub
try:
options = browser_options.BrowserFinderOptions()
@@ -157,6 +157,6 @@ class BenchmarkTest(unittest.TestCase):
b = PredicateBenchmark(page.Page(url='about:blank'))
b.Run(options)
finally:
- user_story_runner.Run = original_run_fn
+ story_runner.Run = original_run_fn
self.assertTrue(validPredicate[0])
« no previous file with comments | « tools/telemetry/telemetry/benchmark.py ('k') | tools/telemetry/telemetry/internal/story_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698