[Contextual Search] Remove opt-in code.

[Contextual Search] Remove opt-in code.

This CL requires a downstream change:
https://chrome-internal-review.googlesource.com/#/c/214963/

BUG=482618
R=donnd@chromium.org, dtrainor@chromium.org, thakis@chromium.org

Committed: https://crrev.com/277f043bb56fb1e4bb93d9d17fc3de4ada0eb81b
Cr-Commit-Position: refs/heads/master@{#330227}

[pedro (no code reviews), 2015-04-30 18:14:57]

pedrosimonetti@chromium.org changed reviewers:
+ donnd@chromium.org

[pedro (no code reviews), 2015-04-30 18:15:41]

Hey Donn, please take a first look at this change. Please note that it requires
a downstream change.

[pedro (no code reviews), 2015-04-30 18:16:57]

pedrosimonetti@chromium.org changed reviewers:
+ mathp@chromium.org

[pedro (no code reviews), 2015-04-30 18:16:58]

Hey Mathieu, we are removing the code for the opt-in flow now that we've
switched to a opt-out model. Could you please take a look at this change and
confirm that we're not forgetting to remove anything? Please note that this
change requires a downstream change (see CL description).

[Mathieu, 2015-04-30 18:29:33]

Hi Pedro, 

It certainly looks like everything is gone! So much for all that work :|

[Donn Denman, 2015-04-30 20:06:14]

LGTM except for the TODO's you've got for yourself to decide.

https://codereview.chromium.org/1103163004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java
(right):

https://codereview.chromium.org/1103163004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java:200:
* @return Whether the Panel Promo is available.
Nit: remove "Panel" from the comment too.

https://codereview.chromium.org/1103163004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java:1181:
/**
Nit: remove "Search" from this comment, and several others below?

https://codereview.chromium.org/1103163004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java:1184:
private boolean mIsSearchPromoViewVisible = false;
Nit: rename to remove "Search"?

https://codereview.chromium.org/1103163004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelStateHandler.java
(right):

https://codereview.chromium.org/1103163004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelStateHandler.java:172:
ArrayList<PanelState> validStates =
I think we can make this a static final member now, since it's no longer
variable.

https://codereview.chromium.org/1103163004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java
(right):

https://codereview.chromium.org/1103163004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagementDelegate.java:27:
boolean isOptOutPromoAvailable();
Nit: maybe deprecate this one and add the different name to land upstream/down?

[pedro (no code reviews), 2015-05-06 00:22:48]

NO ACTION REQUIRED. Just syncing. We're waiting a few days before submitting
this change because we only have limited time before the launch. I'm going to
revisit this change next week.

[pedro (no code reviews), 2015-05-15 19:30:04]

pedrosimonetti@chromium.org changed reviewers:
+ dtrainor@chromium.org, thakis@chromium.org

[pedro (no code reviews), 2015-05-15 19:30:05]

thakis@chromium.org: Please review changes in:
chrome/browser/browser_resources.grd

dtrainor@chromium.org: Please review changes in:
chrome/android/*

[Nico, 2015-05-15 19:48:33]

gtd change lgtm

[Nico, 2015-05-15 19:48:39]

grd change, even

[Donn Denman, 2015-05-15 20:09:48]

lgtm

I'm OK with you just changing the "DO NOT SUBMIT" to simple TODO's if you want
to land this right away.

https://codereview.chromium.org/1103163004/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
(right):

https://codereview.chromium.org/1103163004/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java:78:
* TODO(pedrosimonetti): DO NOT SUBMIT: use it or remove it!
Should resolve these "DO NOT SUBMIT" notes.

[pedro (no code reviews), 2015-05-15 21:29:08]

Thanks Donn, sorry I forgot to remove those! Please take another look.

https://codereview.chromium.org/1103163004/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
(right):

https://codereview.chromium.org/1103163004/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java:78:
* TODO(pedrosimonetti): DO NOT SUBMIT: use it or remove it!
On 2015/05/15 20:09:48, Donn Denman wrote:
> Should resolve these "DO NOT SUBMIT" notes.

Done.

[Donn Denman, 2015-05-15 21:34:51]

On 2015/05/15 21:29:08, pedrosimonetti wrote:
> Thanks Donn, sorry I forgot to remove those! Please take another look.
> 
>
https://codereview.chromium.org/1103163004/diff/80001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
> (right):
> 
>
https://codereview.chromium.org/1103163004/diff/80001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java:78:
> * TODO(pedrosimonetti): DO NOT SUBMIT: use it or remove it!
> On 2015/05/15 20:09:48, Donn Denman wrote:
> > Should resolve these "DO NOT SUBMIT" notes.
> 
> Done.

LGTM

[David Trainor- moved to gerrit, 2015-05-15 22:07:16]

chrome/android lgtm

[pedro (no code reviews), 2015-05-15 22:09:12]

The CQ bit was checked by pedrosimonetti@chromium.org

[pedro (no code reviews), 2015-05-15 22:09:12]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1103163004/#ps100001
(title: "Addressing Donn's comments")

[commit-bot: I haz the power, 2015-05-15 22:09:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1103163004/100001

[aurimas (slooooooooow), 2015-05-15 23:20:10]

Committed patchset #6 (id:100001) manually as
277f043bb56fb1e4bb93d9d17fc3de4ada0eb81b (presubmit successful).

[pedro (no code reviews), 2015-05-16 00:24:45]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1123313006/ by pedrosimonetti@chromium.org.

The reason for reverting is: It broke Clank bots..

[commit-bot: I haz the power, 2015-05-18 11:28:55]

Patchset 6 (id:??) landed as
https://crrev.com/277f043bb56fb1e4bb93d9d17fc3de4ada0eb81b
Cr-Commit-Position: refs/heads/master@{#330227}