Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3943)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java

Issue 1103163004: [Contextual Search] Remove opt-in code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing Donn's comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
index c0b5e1bb095bcb636d6c12bda36d8adedba085ec..b944ef99212887f5edb2e609ed8f6bb089131348 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
@@ -412,17 +412,6 @@ public class ContextualSearchUma {
* Logs the state of the Contextual Search preference. This function should be called if the
* Contextual Search feature is enabled, and will track the different preference settings
* (disabled, enabled or uninitialized). Calling more than once is fine.
- * This is deprecated; pass the number of taps remaining to logPreferenceState.
- */
- @Deprecated
- public static void logPreferenceState() {
- logPreferenceState(PROMO_TAPS_REMAINING_INVALID);
- }
-
- /**
- * Logs the state of the Contextual Search preference. This function should be called if the
- * Contextual Search feature is enabled, and will track the different preference settings
- * (disabled, enabled or uninitialized). Calling more than once is fine.
* @param promoTapsRemaining The number of taps remaining, or -1 if not applicable.
*/
public static void logPreferenceState(int promoTapsRemaining) {
@@ -445,16 +434,6 @@ public class ContextualSearchUma {
}
/**
- * Logs the outcome of a first run flow.
- * This is deprecated; call logPromoOutcome instead.
- */
- @Deprecated
- public static void logFirstRunFlowOutcome() {
- RecordHistogram.recordEnumeratedHistogram("Search.ContextualSearchFirstRunFlowOutcome",
- getPreferenceValue(), PREFERENCE_HISTOGRAM_BOUNDARY);
- }
-
- /**
* Logs the outcome of the promo (first run flow).
* Logs multiple histograms; with and without the originating gesture.
* @param wasTap Whether the gesture that originally caused the panel to show was a Tap.

Powered by Google App Engine
This is Rietveld 408576698