Chromium Code Reviews
Help | Chromium Project | Sign in
(893)

Issue 11031005: Add "standalone_static_library" flag (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by borenet
Modified:
1 year, 6 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Add "standalone_static_library" target flag

This flag is only valid for targets of type "static_library"

Adding 'standalone_static_library': 1, ensures:
1) "thin" archive optimisation is disabled for this target (it will contain
symbols)
2) The static_library will be "installed" to PRODUCT_DIR

This change re-lands r1510-1512.

Landed in gyp r1516/r1517

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Total comments: 4

Patch Set 14 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -9 lines) Lint Patch
M pylib/gyp/generator/make.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +23 lines, -6 lines 0 comments 0 errors Download
M pylib/gyp/generator/msvs.py View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments 0 errors Download
M pylib/gyp/generator/ninja.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +14 lines, -3 lines 0 comments 0 errors Download
M pylib/gyp/input.py View 1 2 3 4 3 chunks +7 lines, -0 lines 0 comments ? errors Download
M test/configurations/invalid/gyptest-configurations.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments ? errors Download
A test/configurations/invalid/standalone_static_library.gyp View 1 2 3 1 chunk +17 lines, -0 lines 0 comments ? errors Download
A test/standalone-static-library/gyptest-standalone-static-library.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +53 lines, -0 lines 0 comments ? errors Download
A test/standalone-static-library/invalid.gyp View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments ? errors Download
A test/standalone-static-library/mylib.c View 1 2 3 1 chunk +7 lines, -0 lines 0 comments 2 errors Download
A test/standalone-static-library/mylib.gyp View 1 2 3 1 chunk +26 lines, -0 lines 0 comments ? errors Download
A test/standalone-static-library/prog.c View 1 2 3 1 chunk +7 lines, -0 lines 0 comments 2 errors Download
Trybot results:
Commit:

Messages

Total messages: 21
borenet
There is a good bit of demand in Skia for this feature (see skia-discuss, where ...
1 year, 6 months ago #1
Ryan Sleevi
https://codereview.chromium.org/11031005/diff/1/pylib/gyp/generator/make.py File pylib/gyp/generator/make.py (right): https://codereview.chromium.org/11031005/diff/1/pylib/gyp/generator/make.py#newcode1993 pylib/gyp/generator/make.py:1993: if generator_flags.get('fat_static_libraries', False): random drive by: If you're going ...
1 year, 6 months ago #2
borenet
https://codereview.chromium.org/11031005/diff/1/pylib/gyp/generator/make.py File pylib/gyp/generator/make.py (right): https://codereview.chromium.org/11031005/diff/1/pylib/gyp/generator/make.py#newcode1993 pylib/gyp/generator/make.py:1993: if generator_flags.get('fat_static_libraries', False): On 2012/10/01 17:39:54, Ryan Sleevi wrote: ...
1 year, 6 months ago #3
Sam Clegg
On 2012/10/01 18:07:10, borenet wrote: > https://codereview.chromium.org/11031005/diff/1/pylib/gyp/generator/make.py > File pylib/gyp/generator/make.py (right): > > https://codereview.chromium.org/11031005/diff/1/pylib/gyp/generator/make.py#newcode1993 > ...
1 year, 6 months ago #4
borenet
Uploaded patch set 2. Since I didn't meet a lot of resistance to the idea ...
1 year, 6 months ago #5
Nico (ooo Apr 18 - Apr 20)
This is to disable the thin archive optimization on a per-target level, right? I thoguht ...
1 year, 6 months ago #6
Mark Mentovai
As written, I don’t think this will work properly. static_library has special meanings in input.py ...
1 year, 6 months ago #7
borenet
I agree that it doesn't make a lot of sense to have two almost-identical target ...
1 year, 6 months ago #8
Nico (ooo Apr 18 - Apr 20)
On 2012/10/02 12:09:23, borenet wrote: > I agree that it doesn't make a lot of ...
1 year, 6 months ago #9
borenet
On 2012/10/02 12:41:26, Nico wrote: > On 2012/10/02 12:09:23, borenet wrote: > > I agree ...
1 year, 6 months ago #10
borenet
Uploaded patch set 3, which instead adds a "standalone_static_library" flag.
1 year, 6 months ago #11
Nico (ooo Apr 18 - Apr 20)
Thanks, I like this much better. . Can you update the CL description with the ...
1 year, 6 months ago #12
borenet
Uploaded patch set 4, which adds a test.
1 year, 6 months ago #13
Nico (ooo Apr 18 - Apr 20)
LGTM! Let me know if you want me to land this. (In that case, I ...
1 year, 6 months ago #14
borenet
On 2012/10/03 03:42:14, Nico wrote: > LGTM! > > Let me know if you want ...
1 year, 6 months ago #15
Nico (ooo Apr 18 - Apr 20)
On 2012/10/03 12:04:06, borenet wrote: > On 2012/10/03 03:42:14, Nico wrote: > > LGTM! > ...
1 year, 6 months ago #16
borenet
On 2012/10/03 14:06:13, Nico wrote: > On 2012/10/03 12:04:06, borenet wrote: > > On 2012/10/03 ...
1 year, 6 months ago #17
Nico (ooo Apr 18 - Apr 20)
https://codereview.chromium.org/11031005/diff/15016/pylib/gyp/generator/make.py File pylib/gyp/generator/make.py (right): https://codereview.chromium.org/11031005/diff/15016/pylib/gyp/generator/make.py#newcode1544 pylib/gyp/generator/make.py:1544: if (sys.platform.startswith('linux') and not Basing this off the host ...
1 year, 6 months ago #18
borenet
Uploaded patch set 14, which succeeds on all trybots. https://codereview.chromium.org/11031005/diff/15016/pylib/gyp/generator/make.py File pylib/gyp/generator/make.py (right): https://codereview.chromium.org/11031005/diff/15016/pylib/gyp/generator/make.py#newcode1544 pylib/gyp/generator/make.py:1544: ...
1 year, 6 months ago #19
Nico (ooo Apr 18 - Apr 20)
Landed in gyp 1516 / 1517. Thanks for the patch!
1 year, 6 months ago #20
borenet
1 year, 6 months ago #21
On 2012/10/05 04:24:01, Nico wrote:
> Landed in gyp 1516 / 1517. Thanks for the patch!

Thanks for taking your time to review/commit it!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6